Skip to content

Revert "Remove System.Deployment.Application xrefs" - #13061

Merged
gewarren merged 3 commits into
mainfrom
revert-13041-fix-xrefs
Sep 9, 2026
Merged

gewarren merged 3 commits into
mainfrom
revert-13041-fix-xrefs

Conversation

@gewarren

@gewarren gewarren commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Reverts #13041

These APIs were inadvertently removed from Learn when a filter was put in place. The filter has now been removed in dotnet/msbuild-api-docs#70.


Internal previews

File Preview link
xml/Microsoft.VisualBasic.ApplicationServices/AssemblyInfo.xml Learn preview
xml/Microsoft.VisualBasic.ApplicationServices/ConsoleApplicationBase.xml Learn preview

Build report

Copilot AI lite review requested due to automatic review settings September 9, 2026 21:49
@gewarren
gewarren requested a review from 333fred as a code owner September 9, 2026 21:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

There are small but concrete documentation/formatting issues introduced in the updated remarks (notably awkward wording and redundant blank lines) that should be corrected before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR reverts a prior change that removed System.Deployment.Application cross-references, restoring ClickOnce-related API links so the affected docs remain discoverable on Learn after the upstream filter change.

Changes:

  • Restores ClickOnce guidance by linking to System.Deployment.Application.ApplicationDeployment members (for example, ActivationUri and CurrentVersion).
  • Adds an altmember entry for ApplicationDeployment.CurrentVersion to improve related-links navigation.
  • Adjusts Markdown table formatting in affected remarks blocks.
File summaries
File Description
xml/Microsoft.VisualBasic.ApplicationServices/ConsoleApplicationBase.xml Updates ClickOnce note to point to ApplicationDeployment.ActivationUri and tweaks table formatting in remarks.
xml/Microsoft.VisualBasic.ApplicationServices/AssemblyInfo.xml Updates ClickOnce version guidance to reference ApplicationDeployment.CurrentVersion, adds an altmember, and tweaks table formatting in remarks.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread xml/Microsoft.VisualBasic.ApplicationServices/AssemblyInfo.xml Outdated
Comment thread xml/Microsoft.VisualBasic.ApplicationServices/AssemblyInfo.xml Outdated
Comment thread xml/Microsoft.VisualBasic.ApplicationServices/ConsoleApplicationBase.xml Outdated
gewarren and others added 2 commits September 9, 2026 14:53
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@gewarren
gewarren enabled auto-merge (squash) September 9, 2026 21:55
@gewarren
gewarren merged commit 41bd671 into main Sep 9, 2026
7 checks passed
@gewarren
gewarren deleted the revert-13041-fix-xrefs branch September 9, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants