Skip to content

[build] Serialize Gradle wrapper projects - #12424

Merged
jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-serialize-gradle-projects
Aug 18, 2026
Merged

jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-serialize-gradle-projects

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Pull Request
title and
description
should follow the
commit-messages.md workflow documentation, and in particular should include:

  • Useful description of why the change is necessary.

    Parallel solution builds can launch proguard-android alongside other projects using the shared Gradle wrapper. Gradle 9.4.1 can then fail while starting a single-use daemon with Timeout waiting to connect to the Gradle daemon as the processes contend on the shared daemon registry.

    Add an ordering-only reference from proguard-android to r8. Since r8 already waits on manifestmerger, this places all wrapper projects in one serialized chain while preserving the direct androidsdk dependency.

  • Links to issues fixed

    N/A

  • Unit tests

    N/A - this changes only MSBuild project ordering. The proguard-android project chain builds successfully.

Prevent concurrent single-use Gradle daemons from racing on the shared daemon registry during parallel solution builds.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b034b140-f3bb-448c-8e47-ec4fd8d6100d
Copilot AI lite review requested due to automatic review settings August 18, 2026 17:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the internal build graph to prevent parallel builds from running multiple Gradle-wrapper-based projects at the same time, reducing Gradle daemon startup contention (e.g., “Timeout waiting to connect to the Gradle daemon”) during solution builds.

Changes:

  • Add an ordering-only ProjectReference from proguard-android to r8 to serialize Gradle wrapper project execution.
  • Document the intent inline in proguard-android.csproj with a short comment.

@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@jonathanpeppers jonathanpeppers added the ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). label Aug 18, 2026

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering-only project reference safely serializes Gradle wrapper builds without introducing graph cycles or output dependencies.

@jonathanpeppers
jonathanpeppers merged commit 189444a into main Aug 18, 2026
43 of 45 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-serialize-gradle-projects branch August 18, 2026 20:24
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants