Repository navigation
chore(go): 1.26.10 - #1088
Merged
Merged
chore(go): 1.26.10#1088
Conversation
mat007
marked this pull request as ready for review
October 21, 2026 08:13
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="Dockerfile" line_range="3" />
<code_context>
# syntax=docker/dockerfile:1
-ARG GO_VERSION=1.25
+ARG GO_VERSION=1.26.10
ARG LLAMA_SERVER_VERSION=b9879
ARG LLAMA_SERVER_VARIANT=cpu
</code_context>
<issue_to_address>
**Docker builds lose security bump**
When a maintainer runs `scripts/sync-go-version.sh check` or `sync` while `go.mod` remains at 1.25.8, `check` reports the Dockerfile defaults as mismatches, and `sync` rewrites them to 1.25, undoing the Go 1.26 security-toolchain bump for builds using those defaults.
Update the script and validation to preserve the intentional Go 1.26 Docker defaults.
Also at `cmd/cli/Dockerfile:3`, `.github/workflows/release-dmr.yml:51`.
</issue_to_address>
mat007
force-pushed
the
chore-go-1.26.10
branch
from
October 21, 2026 08:46
9b2bada to
c5b39be
Compare
Go 1.26.10 and 1.27.3 distrust the compromised eMudhra intermediates, 1.25 does not get the fix. The go directive in go.mod moves with it. It was lowered to 1.25.8 so Docker Desktop could import the module, but Docker Desktop is on 1.27 now. go.mod, .versions and the Dockerfile defaults agree again, the latter two exactly as make validate-versions requires.
mat007
force-pushed
the
chore-go-1.26.10
branch
from
October 21, 2026 08:55
c5b39be to
53a8f44
Compare
doringeman
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Go to 1.26.10, which has the fix for the eMudhra CA security issue. 1.25 doesn’t get it.
The
goline ingo.modmoves too. #756 lowered it so Docker Desktop could import the module, but Desktop is on Go 1.27 now. That also keepsgo.mod,.versionsand the Dockerfile defaults in agreement forsync-go-version.sh.I haven’t run CI yet, and I’m not sure how golangci-lint v2.12.2 behaves with a 1.26 toolchain 🤔