Repository navigation
gha/e2e: Also test against moby master - #7359
Merged
Merged
Conversation
Add a "master" engine-version to the e2e matrix to catch regressions against the upcoming engine release before it reaches an rc. There is no "master" dind image, so just copy the engine binary from the moby/moby-bin:master image and put it into the latest dind image. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
reviewed
Oct 7, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The multi-stage Dockerfile pattern is correct. moby/moby-bin:master stores its daemon binaries directly at the root of the image filesystem (/dockerd, /containerd, /docker-proxy), so COPY --link --from=moby/moby-bin:master / /usr/local/bin/ correctly places them at /usr/local/bin/dockerd etc. — the implementation matches the intent.
Dismissed security findings (review manually)
e2e/testdata/Dockerfile.connhelper-ssh:13 —moby/moby-bin:masteris a mutable tag (verifier mitigation: intentional by design — the test's purpose is to track Moby master; pinning a digest would defeat it; test-only context, not production)e2e/testdata/engine/Dockerfile:9 —moby/moby-bin:masteris a mutable tag (verifier mitigation: same as above — intentional design for a test that tracks the bleeding-edge engine release)
docker-agent
reviewed
Oct 7, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "master" engine-version to the e2e matrix to catch regressions against the upcoming engine release before it reaches an rc.
There is no "master" dind image, so just copy the engine binary from the moby/moby-bin:master image and put it into the latest dind image.
Summary
Release notes (optional)
A picture of a cute animal (not mandatory but encouraged)