Repository navigation
cmd/docker: Add guidance for unavailable cloud plugins - #7358
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
docker-agent
reviewed
Oct 7, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
nico1510
marked this pull request as ready for review
October 7, 2026 12:40
docker-agent
reviewed
Oct 7, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
This review covers only the commits since 216e638.
Assessment: 🟢 APPROVE
aevesdocker
reviewed
Oct 7, 2026
| // the __resolve-context contract. | ||
| const cloudResolverFeature = "cloud-context-resolver" | ||
|
|
||
| const cloudPluginHelp = "Docker Desktop is required to use --cloud.\n" + |
Contributor
There was a problem hiding this comment.
nit: could simplify with `To use --cloud, install Docker Desktop. See [docs])
aevesdocker
reviewed
Oct 7, 2026
Explain how to install the Offload plugin when --cloud cannot find it, and link to the cloud flag documentation. Preserve diagnostic details for invalid or incompatible plugins and limit installation guidance to Offload. Use standard default-value handling in the resolution tests to satisfy the lint complexity limit without changing test coverage. Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com> Signed-off-by: Nicolas Beck <nicolas.beck@docker.com>
nico1510
force-pushed
the
cloud-plugin-guidance
branch
from
October 7, 2026 16:48
78ad450 to
374636f
Compare
vvoland
force-pushed
the
cloud-plugin-guidance
branch
3 times, most recently
from
October 7, 2026 16:51
31a8ac8 to
374636f
Compare
vvoland
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #7343.
Summary
When
docker --cloudcannot find the Offload plugin, tell users: "to use --cloud, install Docker Desktop. See https://docs.docker.com/go/cloud-flag/". Invalid plugins and plugins without--cloudsupport retain their diagnostic details and include the same guidance.Keep Docker Desktop guidance specific to the Offload plugin so configured providers receive accurate errors. Use standard default-value handling in the resolution tests to keep their complexity within the lint limit while preserving every test case.
Validation: all 90 CLI unit-test packages pass with Go 1.27.1, and the repository's pinned
docker buildx bake lintcheck passes.Documentation prerequisite: docker/docs#26303 adds https://docs.docker.com/go/cloud-flag/. Publish the redirect before merging.