Repository navigation
Fix formatting JSON export via PVSystem.payload_to_file - #45
Merged
Merged
Conversation
Always rebuild the payload from current plant configuration, avoiding stale payloads after edits. Store the last built or sent JSON for inspection, but omit it from saved configurations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep unset derived inputs as None and resolve them from final plant settings on a copy during payload construction and description. This makes the documented assign-after-construction workflow order-independent and prevents design calculations from overwriting the user's capacities or GCR. Reduce __setattr__ to enum coercion and remove hidden auto-fill tracking. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document case-insensitive enum inputs, build-time derived defaults, and output-only payload behavior. Widen the enum field annotations to include string inputs and record the compatibility changes in the changelog. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix inverter efficiency formatting in set_inverter_from_rcl error * Add regression test for set_inverter_from_rcl efficiency formatting Cover the "Narrow your search" ValueError raised when multiple inverters match, asserting efficMax is listed as a percentage (eff=98.6%) rather than scaled by 100. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add changelog entry for set_inverter_from_rcl efficiency fix Also strips a trailing space on an existing 0.7.0 entry, as enforced by the trailing-whitespace pre-commit hook. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Ian Tse <ian.tse@dnv.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…data-types-naming Feature/allow flexibility data types naming
…rebased payload_to_file fix
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iantsednv
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix formatting of JSON export via PVSystem.payload_to_file() to have the correct multi-line formatting and indentation.