Repository navigation
Initial phase of scikit-package migration - #56
Merged
Merged
Conversation
…eqs to requirements/
…s to point to the rst file
cadenmyers13
marked this pull request as draft
October 20, 2026 18:17
Author
Claude generated:Versioning and release
CI details
Documentation
Leftover template and legacy files
Process
Separate issues (not blocking)
|
cadenmyers13
marked this pull request as ready for review
October 21, 2026 13:22
Author
|
@sbillinge ready for review. Another PR will be put in for more changes, but it would be good to get this merged to keep edits on this PR low PS, @SYMSCAE helped me with this on a call yesterday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Starts the migration of libdiffpy to the scikit-package standard. libdiffpy is a pure C++ library built with SCons, so only the non-Python parts of the template apply. The SCons build is unchanged.
Changes so far:
requirements/with the C++ build and test dependencies (cxx-compiler,scons,libboost-devel,gsl,libobjcryst,cxxtest,gcovr).README.md,LICENSE.txt,AUTHORS.txt, andCHANGELOG.mdto.rst, keeping the project content. Updated the license and authors references in all source file headers.conda-recipe/for the retireddiffpychannel (conda-forge has its own feedstock)setup.py,src/libdiffpy/,tests/,MANIFEST.in,requirements/pip.txt, and thepyproject.tomlpackage metadata; only the tool config is kept).gitignore.tests-on-pr.yml: a new workflow that builds and runs the C++ tests with SCons in a conda-forge-only environment and uploads C++ coverage to Codecov.release-github-on-tag.yml: releases to GitHub on tag using the scikit-package release scripts, without building a Python wheel.Still to do:
matrix-and-codecov.ymlandbuild-and-publish-docs-on-dispatch.ymlwith SCons-based versionsdoc/manualintodocs/and replacing the empty API page