Skip to content

ci: remove the diffpy.srfit 3.4.0rc0 bridge and require srfit>=3.4.0 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbillinge merged 1 commit into from
Oct 27, 2026
Merged

ci: remove the diffpy.srfit 3.4.0rc0 bridge and require srfit>=3.4.0 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/matrix-and-codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,5 @@ jobs:
project: diffpy.cmistructure
c_extension: false
headless: false
run: |
set -Eeuo pipefail
python -m pip install --no-deps diffpy.srfit==3.4.0rc0
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
3 changes: 0 additions & 3 deletions .github/workflows/tests-on-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,5 @@ jobs:
project: diffpy.cmistructure
c_extension: false
headless: false
run: |
set -Eeuo pipefail
python -m pip install --no-deps diffpy.srfit==3.4.0rc0
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
23 changes: 23 additions & 0 deletions news/rm-srfit-rc-pin.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* <news item>

**Changed:**

* <news item>

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* Require ``diffpy.srfit`` 3.4.0 or later. Older versions lack the methods diffpy.cmistructure calls, so installing it next to ``diffpy.srfit`` 3.3.1 failed at run time.

**Security:**

* <news item>
2 changes: 1 addition & 1 deletion requirements/conda.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
numpy
diffpy.srreal
diffpy.srfit
diffpy.srfit>=3.4.0

@cadenmyers13 cadenmyers13 Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pins are useful because if someone has a srfit less than 3.4.0 and they change to cmistructure it will not work. having this will autoupdate their srfit

diffpy.structure
pyobjcryst
2 changes: 1 addition & 1 deletion requirements/pip.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
numpy
diffpy.srreal
diffpy.srfit
diffpy.srfit>=3.4.0
diffpy.structure
pyobjcryst
Loading