refactor(e2e): call framework.DevsySSH directly

[skevetter]

What changed

• Deleted the execSSH forwarder method on baseTestContext in e2e/tests/up/helper.go and e2e/tests/up-docker-compose/helper.go. It only forwarded to btc.f.DevsySSH(ctx, tempDir, command).
• Rewrote all 100 <recv>.execSSH(...) call sites to <recv>.f.DevsySSH(...) with the same arguments in the same order. Files: up/{helper,provider_docker,sops,up_behaviors}.go, up-docker-compose/{config,up_docker_compose}.go.
• execSSHCapture (runs devsy workspace ssh --command) is unchanged, along with its callers.
• No imports needed changing. No test expectations, labels, or structure changed.
• The call sites were rewritten with a go/ast-driven byte splice that only replaces the execSSH identifier. task cli:format then re-wrapped about 20 calls that became too long. Those are formatter-only line wraps.

Why

Same duplicated-forwarder theme as #1481. execSSH added no behaviour over framework.DevsySSH, so the indirection is removed and callers use the framework method directly.

Verification

• git grep -n "\.execSSH(" -- e2e: no matches.
• task cli:format: exit 0, only the 7 touched files changed.
• task cli:lint:ci: exit 0, 0 issues.
• go vet ./e2e/...: exit 0.
• go test -count=1 -run xxx ./e2e/...: exit 0 (compile-only). up and up-docker-compose compile.
• Docker/Podman/Microsandbox e2e tests were not run, per scope.

CodeRabbit CLI

coderabbit review --agent --committed --base-commit 21c01dd5 completed with 0 findings across the 7 reviewed files.

Skipped findings

None.

Summary by CodeRabbit

• Tests
  • Updated end-to-end checks to use the framework’s standard remote-command access across Docker Compose and Docker provider scenarios.
  • Existing test commands, expected results, and assertions remain unchanged; no user-facing behavior changed.

[netlify]

✅ Deploy Preview for images-devsy-sh canceled.

Name	Link
🔨 Latest commit	074ed25
🔍 Latest deploy log	https://app.netlify.com/projects/images-devsy-sh/deploys/6acfbaa2704e0f2bb2eea80e

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2f553ae2-5057-4903-b57f-3d4d87e17b2d

📥 Commits

Reviewing files that changed from the base of the PR and between 21c01dd and 074ed25.

📒 Files selected for processing: 7

• e2e/tests/up-docker-compose/config.go
• e2e/tests/up-docker-compose/helper.go
• e2e/tests/up-docker-compose/up_docker_compose.go
• e2e/tests/up/helper.go
• e2e/tests/up/provider_docker.go
• e2e/tests/up/sops.go
• e2e/tests/up/up_behaviors.go

💤 Files with no reviewable changes: 1

• e2e/tests/up-docker-compose/helper.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The end-to-end tests now use Framework.DevsySSH directly for remote commands. The unexported execSSH wrappers were removed. The test commands and assertions remain unchanged.

Changes: End-to-end SSH calls

Layer / File(s)	Summary
Replace SSH wrapper calls e2e/tests/up-docker-compose/*, e2e/tests/up/*	Tests call Framework.DevsySSH directly for remote checks. The execSSH wrappers were removed. Existing commands and assertions remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 074ed

This is a test-only refactor that removes a redundant helper. It does not change product behavior, and no merge-blocking risk was found.

Pre-merge checks: 5

Passed checks: 5 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: replacing the removed e2e execSSH wrapper with direct framework.DevsySSH calls.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

✨ Simplify code

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[netlify]

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	074ed25
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/6acfbaa2ca70218835b3c785

[mergify]

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.