Repository navigation
fix: keep 1.11 enabled, prune flags and state pull behaviour - #177
Merged
Merged
Conversation
Restore what 1.11.0 users rely on: - monitors accept enabled in devhelm.yml (and defaults.monitors); sent on create only when set, sent as enabled ?? null on update - deploy --prune-org-cli / --prune-all and plan --prune-all widen the delete scope as in 1.11; plain --prune also covers this project's own monitors - state pull scopes monitors to project: only when the config sets it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
caballeto
force-pushed
the
fix/compat-1-11
branch
from
October 26, 2026 13:25
9dd6d68 to
fed8f69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unreleased 1.12 must not break anything a 1.11.0 user relies on. This PR restores three 1.11 behaviours.
enabled:on monitors (anddefaults.monitors.enabled) is accepted again, as it was in 1.11.enabled ?? null, andnullkeeps the current value.enabledis absent, deploy never touches the pause state.enabled, as it did in 1.11.deploy --prune-org-cli/--prune-allandplan --prune-allare visible again, with their 1.11 descriptions.--pruneand widen the scope throughclassifyDeleteScope:stateorg-cliorg-allorg-cli--prunekeeps main's behaviour:.devhelm/state.jsonplus this project's own monitors.removedPruneFlagis removed.state pullwithproject:is scoped to the project, as on main. Withoutproject:it pulls every monitor (the 1.11 behaviour) and prints no warning.monitors pausedescription, themonitors exportfidelity note, the plan overlay line and the synthetics skill no longer sayenabledis refused.Tests
npm run lint,npm run typecheckandnpm testall pass locally: 63 files, 1250 tests.New or updated tests:
enabledenabledonly when it is set, andnullon update when it is absentenabledchangepruneAllandpruneOrgCliscopesstate pullscope with and withoutproject:Self-review
One Sonnet pass found no P0s. I fixed P1 #1: the plan overlay line said "not changed by deploy", which is wrong now. Follow-ups I left:
--prunenow also deletes this project's own monitors that are not in state. This is main's behaviour, kept on purpose, and the CHANGELOG says so.state pullwithoutproject:puts every org monitor into state. This is 1.11 behaviour.state pullhas no command-level test.🤖 Generated with Claude Code