Repository navigation
fix: name the offending field in devhelm.yml schema errors - #175
Merged
Merged
Conversation
formatIssue printed only the file when an issue carried one, so schema errors read 'devhelm.yml: invalid enum value' without the field. Print file plus field path unless the finding has a line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devhelm validate(and plan/deploy/test vialoadProject) printed schema errors asdevhelm.yml: invalid enum value…with no field path.formatIssuedroppedpathwhenever the issue carried afile. Regression from #168 (doc 42 §6 project loader). Caught by monotests/surfaces/cli/test_negative_yaml.py(test_unknown_monitor_type_rejected,test_empty_escalation_steps).Now:
file:linewhen the finding has a line (code findings, unchanged); otherwisefile: path: message(e.g.devhelm.yml: monitors[0].type: invalid enum value…). The path is not repeated when it equals the file (ignored Playwright keys). JSON output already carriedpath, so it is unchanged.Tests
test/lib/project-format-issue.test.ts(5 tests): realloadProjecton the two mono failure YAMLs plus the three formatting branches.npm run lint,npm run typecheckclean;npm test: 63 files, 1248 tests passed.Not in this PR
formatIssueto stay clear of the concurrentzod-schemas.ts/differ.tswork.🤖 Generated with Claude Code