Repository navigation
fix: keep CI idempotency keys distinct across commands in one job - #172
Merged
Merged
Conversation
The CI seed hashed only the run, attempt and command id, so two different creates of the same kind in one job shared an Idempotency-Key and the second failed with IDEMPOTENCY_KEY_REUSED. The seed now also covers GITHUB_JOB, GITHUB_ACTION and argv; re-running the same step of the same attempt still replays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the mono CLI surface tests (devhelmhq/mono#1438, 71 failures with
IDEMPOTENCY_KEY_REUSED).Bug: in GitHub Actions the key seed was
sha256(GITHUB_RUN_ID, GITHUB_RUN_ATTEMPT, command id), so two differentdevhelm … createcalls in the same job got the same key. The second one was refused, and any customer CI running two creates would hit it.Fix: the seed also covers
GITHUB_JOB,GITHUB_ACTION(the step) and the full argv. Re-running the same step of the same attempt still replays; another command, step or attempt gets a new key. Outside CI the seed stays a random UUID per invocation.Tests: new
test/lib/idempotency-key.test.ts(4 cases); full suite run once.🤖 Generated with Claude Code