Skip to content

feat(mgmt): allow updating management key roles - #1744

Open
dorsha wants to merge 1 commit into
mainfrom
feat/mgmt-key-update-roles
Open

dorsha wants to merge 1 commit into
mainfrom
feat/mgmt-key-update-roles

Conversation

@dorsha

@dorsha dorsha commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Related Issues

Required for:
https://github.com/descope/etc/issues/19637

Description

Management key update (sync and async) takes an optional rebac argument that replaces the key's roles without rotating its secret. Leaving it out keeps the key's current roles, so existing calls behave the same.

Related PRs

Related PRs

Must

  • Tests
  • Documentation (if applicable)

🤖 Generated with Claude Code

Management key update accepts an optional rebac parameter that replaces the
key's roles without rotating its secret. When omitted, the key keeps its
current roles.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

🐕 Shuni Review

No new issues found.

🤖 Model: claude-opus-5.5 · Effort: high


Review scope: Full review

Reviewed files (4)
  • README.md
  • descope/management/management_key.py
  • descope/management/management_key_async.py
  • tests/management/test_mgmtkey.py

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-opus-5.5 · Effort: high

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@github-actions

Copy link
Copy Markdown

Coverage report

The coverage rate went from 98.39% to 98.39% ⬆️

100% of new lines are covered.

Diff Coverage details (click to unfold)

descope/management/management_key_async.py

100% of new lines are covered (100% of the complete file).

descope/management/management_key.py

100% of new lines are covered (100% of the complete file).

@dorsha
dorsha requested a review from aviadl October 29, 2026 12:08
@dorsha
dorsha enabled auto-merge (squash) October 29, 2026 12:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant