prince and princess join the given-name titles (#519) - #523
Merged
Merged
Conversation
Both were in the TITLES-only block, so rules.md#H1 familied the one
name word behind them: "Prince Harry" read family 'Harry' with no
given name at every release since 1.4.0. rules.md#H's Background
criterion for membership is HOW THE TITLE ADDRESSES, and a royal
title addresses by the given name -- "Prince Harry", "Princess Anne"
-- with no surname reading of the word behind it. So they move, and
"Prince Harry" reads given 'Harry', family ''. Both read sites move
with it: H1's fold ("Her Royal Highness Princess Anne" reads given
'Anne') and P5's licence ("Prince abdul Rahman" reads given 'abdul
Rahman', as "Sir abdul Rahman" does).
lord and lady stay out, decided rather than deferred. lord addresses
by peerage or surname ("Lord Byron"). lady splits -- a peer's
daughter by given name ("Lady Diana"), a wife by surname ("Lady
Thatcher") -- and the set has no way to say "sometimes", the
venerable reasoning from #346. Both are pinned as negative controls.
Two corpus names move, both from the radar-tier corpus_issues.jsonl:
'Prince Charles' and 'Prince Fielder'. The second is wrong either way
-- Prince is his given name, #348's collision -- and membership
decides only which field the one word takes. 'Prince of Wales Jr'
does not move: the joined run addresses by its last word, `wales`.
TITLES membership is unchanged, TITLES being GIVEN_NAME_TITLES | {...}.
Gate: 411 / 339 / 253 / 116 intentional at 1.4.0 / 2.0.0 / 2.1.0 /
2.2.0, 0 unexplained, 0 radar unclassified.
Closes #519
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
rules.md#H1 gains "Her Royal Highness Princess Anne" as an example and its Accepted clause records why lord and lady stay out: both split by the bearer's rank, which the text does not carry -- the given-name form is a courtesy style for children of the senior ranks alone (Lord Peter, Lady Diana), and every peer and every wife takes the title or surname (Lord Byron, Lady Thatcher). decisions.md#H1 carries the dated entry with the two references that agree on that boundary (Debrett's, Bratman), the measurement -- two corpus names moved at the fix, three once this commit puts the new example in corpus_rules.jsonl -- and the fence: the clause is for the two words, not a royal class, emperor/tsar/sultan and their pairs being unweighed. The fix(#519) ledger rule widens to the three-name alternation and _CORPUS_CLAIMS pins reach 3; the #489 wall's comment no longer describes the princess probe as a family-keeping run. The 2.3.0 release note for #489 no longer names princess as a non-given-name title, 2.3.0 being unreleased, and #519 gets its own note under Additions. Design review (design-docs-reviewer) found three things and all three landed: the royal-class overreach, the lord/lady ground, and the stale #489 guard comment. Gate: 412 / 340 / 254 / 117 intentional at 1.4.0 / 2.0.0 / 2.1.0 / 2.2.0, 0 unexplained, 0 radar unclassified. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #523 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 45 45
Lines 3320 3320
=======================================
Hits 3276 3276
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #519.
princeandprincessmove from the TITLES-only block intoGIVEN_NAME_TITLES, soPrince Harryreads givenHarrywith an empty family, where every release since 1.4.0 read familyHarry. Both read sites move through the shared predicate: rules.md#H1's fold (Her Royal Highness Princess Anne→ givenAnne) and #P5's licence (Prince abdul Rahman→ givenabdul Rahman, asSir abdul Rahmandoes). TITLES membership is unchanged.lordandladystay out, decided rather than deferred. Both split by the bearer's rank, which the text does not carry: the given-name form is a courtesy style for children of the senior ranks alone (Lord Peter,Lady Diana), and every peer and every wife takes the title or surname (Lord Byron,Lady Thatcher). Debrett's and Bratman's peerage primer agree on that boundary and are cited in decisions.md#H1. Pinned as negative controls.Measured: two corpus names move at the fix (
Prince Charles,Prince Fielder, both radar tier), three after the docs commit adds the rules.md example.Prince Fielderis #348's collision either way — membership decides only which field the one word takes.Prince of Wales Jrdoes not move; the joined run addresses bywales. The entry is fenced to the two words:emperor,tsar,sultanand their pairs are unweighed.Design review (
design-docs-reviewer) ran on the docs/design diff; its three findings landed in the docs commit.Gate: 412 / 340 / 254 / 117 intentional at 1.4.0 / 2.0.0 / 2.1.0 / 2.2.0, 0 unexplained, 0 radar unclassified. Full suite 7815 passed;
sphinx-build -Wclean.🤖 Generated with Claude Code