chore: Add regression tests for DataFrame rendering and analysis by m1so · Pull Request #25 · deepnote/deepnote-toolkit

m1so · 2025-11-07T13:08:09Z

Summary by CodeRabbit

Tests
- Strengthened test infrastructure with comprehensive integration tests for Trino STRUCT/ROW and ARRAY types, validating serialization, field access patterns, and data analysis capabilities
- Enhanced DataFrame rendering test suite with extensive coverage for structured data types including nested objects, JSON conversion, and statistical analysis, ensuring data integrity and proper visualization

linear · 2025-11-07T13:08:12Z

BLU-5140 Trino rendering is broken for structs

coderabbitai · 2025-11-07T13:08:27Z

📝 Walkthrough

Walkthrough

Two test suites are added to strengthen type-handling validation. Integration tests in test_trino.py verify correct behavior when Trino STRUCT/ROW and ARRAY types are executed and converted—checking column presence, field access patterns (index and attribute), and JSON serialization. Unit tests in test_dataframe_rendering.py comprehensively validate DataFrame rendering of structured data across multiple scenarios: dicts, lists, tuples, NamedRowTuple instances, nested structures, and mixed types. Both suites confirm that analyze_columns() and to_records() handle complex types without crashes and produce JSON-serializable output.

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PR title 'chore: Add regression tests for DataFrame rendering and analysis' accurately describes the main changes—adding integration and unit tests for structured types.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-11-07T13:08:40Z

📦 Python package built successfully!

Version: 1.1.2.dev7+ff96a56
Wheel: deepnote_toolkit-1.1.2.dev7+ff96a56-py3-none-any.whl

Install:

pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.1.2.dev7%2Bff96a56/deepnote_toolkit-1.1.2.dev7%2Bff96a56-py3-none-any.whl"

codecov · 2025-11-07T13:09:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.39%. Comparing base (7e6cd2a) to head (c322d3d).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   75.39%   75.39%           
=======================================
  Files          99       99           
  Lines        5625     5625           
  Branches      784      784           
=======================================
  Hits         4241     4241           
  Misses       1384     1384

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deepnote-bot · 2025-11-07T13:17:33Z

🚀 Review App Deployment Started

📝 Description	🌐 Link / Info
🌍 Review application	ra-25
🔑 Sign-in URL	Click to sign-in
📊 Application logs	View logs
🔄 Actions	Click to redeploy
🚀 ArgoCD deployment	View deployment
⏰ Last deployed	2025-11-10 11:41:18 (UTC)
📜 Deployed commit	`be2d0f13ef5aa0f9e103e1ed00a284446383a091`
🛠️ Toolkit version	`ff96a56`

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d011e7b and 6f4b085.

📒 Files selected for processing (1)

tests/unit/test_ocelots_pandas_utils.py (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

tests/unit/test_ocelots_pandas_utils.py (1)

deepnote_toolkit/ocelots/pandas/utils.py (1)

safe_convert_to_string (10-35)

🪛 Ruff (0.14.3)

tests/unit/test_ocelots_pandas_utils.py

49-49: Boolean positional value in function call

(FBT003)

57-57: Missing return type annotation for special method __str__

Add return type annotation: str

(ANN204)

58-58: Avoid specifying long messages outside the exception class

(TRY003)

60-60: Missing return type annotation for special method __repr__

Add return type annotation: str

(ANN204)

61-61: Avoid specifying long messages outside the exception class

(TRY003)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: Test - Python 3.10
GitHub Check: Test - Python 3.11
GitHub Check: Test - Python 3.9
GitHub Check: Build and push artifacts for Python 3.9
GitHub Check: Build and push artifacts for Python 3.11
GitHub Check: Build and push artifacts for Python 3.13
GitHub Check: Build and push artifacts for Python 3.12
GitHub Check: Build and push artifacts for Python 3.10

🔇 Additional comments (10)

tests/unit/test_ocelots_pandas_utils.py (10)

1-6: LGTM - Clean imports.

Necessary imports for testing JSON conversion and Trino types.

8-14: LGTM - Solid dict test.

Validates JSON output and round-trip parsing.

17-23: LGTM - Correct tuple→JSON→list handling.

Properly expects list after JSON round-trip (JSON lacks tuple type).

26-32: LGTM - Basic list coverage.

35-40: LGTM - Nested structure coverage.

Critical for complex Trino STRUCT/ARRAY types.

43-51: LGTM - Primitive type coverage.

Static analysis warning on line 49 is a false positive for test code.

54-64: LGTM - Error handling validated.

Static analysis warnings are false positives for test helper class.

68-84: LGTM - NamedRowTuple coverage.

Field access checks (lines 83-84) provide extra validation of Trino type behavior.

87-100: LGTM - Quote validation is excellent.

Lines 99-100 explicitly verify double-quote JSON vs single-quote str() output.

103-113: LGTM - Nested array coverage.

…s-broken-for-structs

coderabbitai

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6f4b085 and 4b40a57.

📒 Files selected for processing (2)

tests/integration/test_trino.py (1 hunks)
tests/unit/test_dataframe_rendering.py (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

tests/unit/test_dataframe_rendering.py (1)

deepnote_toolkit/ocelots/pyspark/implementation.py (1)

to_records (223-282)

tests/integration/test_trino.py (2)

deepnote_toolkit/sql/sql_execution.py (1)

execute_sql (197-233)

deepnote_toolkit/ocelots/pyspark/implementation.py (2)

columns (30-37)

to_records (223-282)

🪛 Ruff (0.14.3)

tests/unit/test_dataframe_rendering.py

20-20: Missing return type annotation for private function _test_rendering_flow

Add return type annotation: None

(ANN202)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: Test - Python 3.9
GitHub Check: Test - Python 3.11
GitHub Check: Test - Python 3.10
GitHub Check: Build and push artifacts for Python 3.9
GitHub Check: Build and push artifacts for Python 3.13
GitHub Check: Build and push artifacts for Python 3.11
GitHub Check: Build and push artifacts for Python 3.10
GitHub Check: Build and push artifacts for Python 3.12

…s-broken-for-structs

fix(trino): convert STRUCT/ROW/ARRAY types to valid JSON strings

d011e7b

coderabbitai Bot previously approved these changes Nov 7, 2025

View reviewed changes

fix: imports due to Trino update (0.327.0 -> 0.330.0)

6f4b085

m1so dismissed coderabbitai[bot]’s stale review via 6f4b085 November 7, 2025 13:21

coderabbitai Bot requested changes Nov 7, 2025

View reviewed changes

Comment thread tests/unit/test_ocelots_pandas_utils.py Outdated

m1so added 2 commits November 7, 2025 15:19

Merge branch 'main' into michalbaumgartner/blu-5140-trino-rendering-i…

08f83d0

…s-broken-for-structs

chore: Add regression tests for DataFrame rendering and analysis

4b40a57

m1so changed the title ~~fix(trino): convert STRUCT/ROW/ARRAY types to valid JSON strings~~ chore: Add regression tests for DataFrame rendering and analysis Nov 7, 2025

coderabbitai Bot requested changes Nov 7, 2025

View reviewed changes

Comment thread tests/integration/test_trino.py

Comment thread tests/integration/test_trino.py

Comment thread tests/unit/test_dataframe_rendering.py

Comment thread tests/unit/test_dataframe_rendering.py

m1so marked this pull request as ready for review November 7, 2025 15:21

m1so requested a review from a team as a code owner November 7, 2025 15:21

coderabbitai Bot approved these changes Nov 7, 2025

View reviewed changes

FilipPyrek approved these changes Nov 10, 2025

View reviewed changes

Merge branch 'main' into michalbaumgartner/blu-5140-trino-rendering-i…

c322d3d

…s-broken-for-structs

m1so enabled auto-merge (squash) November 10, 2025 11:33

m1so merged commit cc6a555 into main Nov 10, 2025
34 checks passed

m1so deleted the michalbaumgartner/blu-5140-trino-rendering-is-broken-for-structs branch November 10, 2025 11:38

Navigation Menu

Repository navigation

chore: Add regression tests for DataFrame rendering and analysis - #25

chore: Add regression tests for DataFrame rendering and analysis#25
m1so merged 5 commits into
mainfrom
michalbaumgartner/blu-5140-trino-rendering-is-broken-for-structs

m1so commented Nov 7, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

linear Bot commented Nov 7, 2025

Uh oh!

coderabbitai Bot commented Nov 7, 2025 •

edited

Loading

Walkthrough

Uh oh!

github-actions Bot commented Nov 7, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Nov 7, 2025 •

edited

Loading

Uh oh!

deepnote-bot commented Nov 7, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

m1so commented Nov 7, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

linear Bot commented Nov 7, 2025

Uh oh!

coderabbitai Bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Pre-merge checks

Uh oh!

github-actions Bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

deepnote-bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

m1so commented Nov 7, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Nov 7, 2025 •

edited

Loading

github-actions Bot commented Nov 7, 2025 •

edited

Loading

codecov Bot commented Nov 7, 2025 •

edited

Loading

deepnote-bot commented Nov 7, 2025 •

edited

Loading