Repository navigation
Show the user in the prompt if a default user was used, instead of (none) - #2373
Merged
Merged
Conversation
instead of "(none)". This is a complete fix for the bug which was papered over for Docker in 6e0d16a. If a username was not given at the CLI with --user, and we fall back to a default user to make the connection, preserve the actual user for the connection in the SQLExecute instance. Later, the prompt correctly fills in the "\u" username escape from the user property of the SQLExecute instance. Storing the actual user instead of a None could be a help to other functionality beyond the prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a complete fix for the bug which was papered over for Docker in 6e0d16a.
If a username was not given at the CLI with
--user, and we fall back to a default user to make the connection, preserve the actual user for the connection in theSQLExecuteinstance.Later, the prompt correctly fills in the
\uusername escape from theuserproperty of theSQLExecuteinstance.Storing the actual user instead of a
Nonecould be a help to other functionality beyond the prompt.xref #2371
Checklist
changelog.mdfile.mycli/AUTHORS.txtfile (or it's already there).