Repository navigation
Apply the timeout to the auth token inline login - #7267
Merged
Merged
Conversation
simonfaltum
approved these changes
Oct 30, 2026
Collaborator
Integration test reportCommit: dc28d3e
Top 6 slowest tests (at least 2 minutes):
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 30, 2026
PersistentAuth.Challenge uses the context passed to NewPersistentAuth, but the timeout context was created after it, so the one hour timeout never applied. Closing the browser tab left auth token waiting until Ctrl+C. Create the timeout context first, as auth login does. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
maksim-zuev-db
force-pushed
the
auth-token-inline-login-timeout
branch
from
October 30, 2026 16:51
2913368 to
dc28d3e
Compare
maksim-zuev-db
enabled auto-merge
October 30, 2026 16:53
Collaborator
Integration test reportCommit: bdd24cf
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
runInlineLoginindatabricks auth tokennow creates its timeout context beforeNewPersistentAuth, asdatabricks auth logindoes.Why
Follow-up to this review on #7196.
PersistentAuth.Challengeuses the context passed toNewPersistentAuth, but the timeout context was created after it, so the one hour timeout never applied. Closing the browser tab leftauth tokenwaiting until Ctrl+C.Tests
cmd/authunit tests pass.defaultTimeoutto be injectable.This pull request and its description were written by Isaac.