Skip to content

acc: record configuration edge cases ahead of the libs/dyn removal - #7085

Draft
denik wants to merge 4 commits into
mainfrom
denik/acc-dyn-parity-tests
Draft

denik wants to merge 4 commits into
mainfrom
denik/acc-dyn-parity-tests

Conversation

@denik

@denik denik commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Twenty bundle validate acceptance tests under acceptance/bundle/validate/parity/, each pinning current behaviour for a configuration edge case:

  • merge keys and aliases in targets.*.variables (inherited through a target or root <<, aliases of a complex default, duplicate and malformed <<, inline mappings),
  • duplicate keys, timestamps as shorthands or nested in complex defaults,
  • references that resolve to the wrong type inside lists and maps,
  • includes overriding fields with "" / 0 / false, diagnostics after a failed include merge,
  • resources: null, targets: false, schedule: null,
  • diagnostic locations for unknown fields in complex variables and duplicated app resources.

Badness marks the ten cases where current behaviour is itself wrong:

  • a timestamp nested in a complex default fails with an internal error; a timestamp shorthand is dropped;
  • an inline mapping as the merge value is rejected although the YAML spec allows it;
  • duplicate keys are accepted silently (the later one wins);
  • an empty resources: section is an error without a location (empty targets, variables, sync are fine); targets: false fails with an internal "failed to rewrite" message;
  • an explicitly null schedule is reported as missing its required fields;
  • an unknown field in a complex variable default is reported at the resource using the variable;
  • diagnostics of includes after a failed merge are hidden.

Why

They guard behaviour ahead of #6954, which replaces libs/dyn: all twenty currently produce different output there.

Tests

Goldens recorded on main.

This pull request and its description were written by Isaac.

Twenty bundle validate tests found by reviewing libs/dyn against the
structvar implementation (#6954): merge keys and aliases in target
variables, duplicate keys, references that resolve to the wrong type,
include overrides with zero values, null blocks, and diagnostic locations.
Each pins the current behaviour; Badness marks the cases where the
current behaviour is itself wrong.

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot added the DABs DABs related issues label Oct 16, 2026
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: cd9e915

Run: 38895069547

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 276 35 5:28
✅​ aws-windows-latest-4core-16gb 278 33 3:29
✅​ azure linux-2core-8gb 275 35 5:19
✅​ azure-windows-latest-4core-16gb 277 33 3:43
✅​ gcp linux-2core-8gb 276 35 5:08
✅​ gcp-windows-latest-4core-16gb 278 33 3:32
Top 6 slowest tests (at least 2 minutes):
duration env testname
3:53 aws linux-2core-8gb TestAccept
3:46 gcp linux-2core-8gb TestAccept
3:41 azure linux-2core-8gb TestAccept
3:37 azure-windows-latest-4core-16gb TestAccept
3:26 gcp-windows-latest-4core-16gb TestAccept
3:22 aws-windows-latest-4core-16gb TestAccept

denik and others added 3 commits October 16, 2026 11:26
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants