Repository navigation
Conversation
Twenty bundle validate tests found by reviewing libs/dyn against the structvar implementation (#6954): merge keys and aliases in target variables, duplicate keys, references that resolve to the wrong type, include overrides with zero values, null blocks, and diagnostic locations. Each pins the current behaviour; Badness marks the cases where the current behaviour is itself wrong. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: cd9e915
Top 6 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Twenty
bundle validateacceptance tests underacceptance/bundle/validate/parity/, each pinning current behaviour for a configuration edge case:targets.*.variables(inherited through a target or root<<, aliases of a complex default, duplicate and malformed<<, inline mappings),""/0/false, diagnostics after a failed include merge,resources: null,targets: false,schedule: null,Badnessmarks the ten cases where current behaviour is itself wrong:resources:section is an error without a location (emptytargets,variables,syncare fine);targets: falsefails with an internal "failed to rewrite" message;scheduleis reported as missing its required fields;Why
They guard behaviour ahead of #6954, which replaces
libs/dyn: all twenty currently produce different output there.Tests
Goldens recorded on main.
This pull request and its description were written by Isaac.