Skip to content

Validate DMS resource types in the test server #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyas-goenka merged 10 commits into from
Oct 19, 2026
Merged

Validate DMS resource types in the test server #7039

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
05fd310
Validate supported DMS resource types in test server
shreyas-goenka Oct 13, 2026
fba87ea
Remove DMS resource validation test file
shreyas-goenka Oct 13, 2026
4c6089e
Assert DMS rejection for unsupported resource types in acceptance tests
shreyas-goenka Oct 14, 2026
17acacb
Cover DMS rejection for immutable development deployments
shreyas-goenka Oct 14, 2026
83f9614
Keep DMS test-server rejection assertions local
shreyas-goenka Oct 14, 2026
67fff13
Allow immutable snapshots in the DMS test server
shreyas-goenka Oct 15, 2026
97545a4
Keep DMS resource validation changes scoped to the test server
shreyas-goenka Oct 15, 2026
1c1048e
Track the remaining Universe resource enum addition
shreyas-goenka Oct 19, 2026
7c21b10
Align the test-server allow list with current Universe resource types
shreyas-goenka Oct 19, 2026
27af372
Remove the resolved Universe resource-type TODO
shreyas-goenka Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 49 additions & 1 deletion libs/testserver/bundledeployments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,53 @@ const dmsDeploymentNodeName = "resources.deployment.json"
// created.
var dmsUpdatableOperationFields = []string{"state", "error_message", "resource_id", "status"}

// dmsResourceTypes lists the resource_key prefixes accepted by DMS.
// NOTE: When adding a type here, also add the corresponding enum in bundle/metadata-service/service.proto
// and prefix mapping in parser/ResourceTypes.java in Universe.
var dmsResourceTypes = []string{
"agent_services",
"alerts",
"apps",
"catalogs",
"cluster_policies",
"clusters",
"dashboards",
"database_catalogs",
"database_instances",
"experiments",
"external_locations",
"genie_spaces",
"instance_pools",
"internal_immutable_folders",
"internal_immutable_snapshots",
"job_runs",
"jobs",
"mcp_services",
"model_provider_services",
"model_services",
"model_serving_endpoints",
"models",
"pipelines",
"postgres_branches",
"postgres_catalogs",
"postgres_databases",
"postgres_endpoints",
"postgres_projects",
"postgres_roles",
"postgres_snapshot_schedules",
"postgres_synced_tables",
"quality_monitors",
"registered_models",
"schemas",
"secret_scopes",
"secrets",
"sql_warehouses",
"synced_database_tables",
"vector_search_endpoints",
"vector_search_indexes",
"volumes",
}

// DmsDeployment holds a deployment record together with the versions and
// resources recorded under it, so the read APIs (ListVersions/ListResources)
// can serve back what deploys wrote.
Expand Down Expand Up @@ -327,10 +374,11 @@ func (s *FakeWorkspace) CreateVersion(req Request, deploymentID string) Response
}
seen := make(map[string]bool, len(staged.Operations))
for _, staged := range staged.Operations {
resourceType, _, hasPrefix := strings.Cut(staged.ResourceKey, ".")
switch {
case staged.ResourceKey == "":
return dmsInvalidArgument("operations.resource_key is required")
case !strings.Contains(staged.ResourceKey, "."):
case !hasPrefix || !slices.Contains(dmsResourceTypes, resourceType):
return dmsInvalidArgument("operations.resource_key must have a known resource type prefix (e.g. 'jobs.', 'pipelines.'): " + staged.ResourceKey)
case staged.ActionType == "":
return dmsInvalidArgument("operations.action_type is required and must not be UNSPECIFIED for resource " + staged.ResourceKey)
Expand Down
Loading