Repository navigation
Support Py_NewRef calls on Python 3.9 - #267
Closed
sricharanreddycheruku wants to merge 1 commit into
Closed
sricharanreddycheruku wants to merge 1 commit into
sricharanreddycheruku wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension calls Py_NewRef, introduced in Python 3.10, but declares
Python >=3.9 support. A normal source-wheel build on Python 3.9 fails with
implicit-declaration and invalid-return-type errors.
Add an eight-line guarded equivalent using Py_INCREF on Python <3.10.
Newer interpreters retain CPython's implementation. Public API and package
requirements stay the same; this does not add release-pipeline wheels.
Original source fails to build on Python 3.9.25; fixed source builds and passes
31 tests under PYTHONMALLOC=debug, with two slow skips and one existing UTF-8
compiler skip. Python 3.12.14 also passes 31 tests with the same skips.
Combined with #265/#266 and the prepared scratch-allocation patch: 96 tests
pass on Python 3.9 with only two slow skips. All patches apply cleanly.
clang-format 9 and diff checks pass. Independent branch from main.
Client integration of the pending Pathspec fixes also passes 250 tests and
1,156 subtests (one skip) on Python 3.9 with all three backends enabled;
RE2 uses its last Python 3.9 wheel, 1.1.20250805.