Repository navigation
test: accept GitHub's rate-limit 403 in BindingIT - #1846
Merged
siri-varma merged 1 commit intoOct 15, 2026
Merged
Conversation
The two HTTP output binding error tests call api.github.com without a token and expected a 404. When the runner's IP has used up GitHub's unauthenticated rate limit, GitHub answers 403 instead and both tests fail. Accept either status and check the body that matches it. Signed-off-by: Javier Aliaga <javier@diagrid.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1846 +/- ##
=========================================
Coverage 79.69% 79.69%
Complexity 2687 2687
=========================================
Files 267 267
Lines 7933 7933
Branches 842 842
=========================================
Hits 6322 6322
Misses 1255 1255
Partials 356 356 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
siri-varma
approved these changes
Oct 15, 2026
dapr-bot
added a commit
that referenced
this pull request
Oct 16, 2026
The two HTTP output binding error tests call api.github.com without a token and expected a 404. When the runner's IP has used up GitHub's unauthenticated rate limit, GitHub answers 403 instead and both tests fail. Accept either status and check the body that matches it. (cherry picked from commit 0d993ca) Signed-off-by: Javier Aliaga <javier@diagrid.io> Co-authored-by: Javier Aliaga <javier@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BindingIT.httpOutputBindingErrorandBindingIT.httpOutputBindingErrorIgnoredByComponentcallhttps://api.github.com/unknown_pathwithout a token and expect a 404. When the runner's IP has used up GitHub's unauthenticated rate limit (60 requests per hour, shared by runners on the same IP), GitHub answers 403 and both tests fail withexpected: <404> but was: <403>.This happened in dapr/dapr's
dapr-test-sdkrun: https://github.com/dapr/dapr/actions/runs/38647323498/job/116137307808The tests now accept 404 or 403:
httpOutputBindingErrorchecks the error message for the status code that was actually returned.httpOutputBindingErrorIgnoredByComponentchecks the body forNot Foundon a 404, orAPI rate limit exceededon a 403.Both cases still check that the binding passes the upstream status and body through to the client.
Issue reference
No issue. CI flake.
Checklist
Verified locally: both tests pass (GitHub answered 404). The 403 path was not exercised locally.