[katerina20]

Follow-up to #423. It resolves the two review questions left open there, checked against the official Crowdin OpenAPI specs.

1. matchType accepts any documented value

In every netRateSchemes schema (translation-costs-pe, costs-estimation-pe, group-translation-costs-pe, and the settings template plus its form), the API types matchType as a free string: perfect, 100, or any percentage range such as 100-82 or 100-74. Match only had the closed MatchType enum. As a result:

• range values without a constant were read as null, so the value was silently lost;
• such ranges could not be sent at all.

Changes in Match:

• New field: String matchTypeValue (getMatchTypeValue()/setMatchTypeValue(String)) holds the raw value under the JSON key matchType.
• Existing accessors kept: getMatchType() and setMatchType(MatchType) keep their exact signatures and work on top of the new field.
  • getMatchType() returns the constant for known values, and null only for ranges without a constant. The original value is always in matchTypeValue.
  • setMatchType(null) clears the value.
• No overload added: there is no setMatchType(String), so existing calls such as setMatchType(null) stay unambiguous.
• Scope: Match is shared by every netRateSchemes, so the fix covers report generation requests and settings templates (requests and responses).

2. Deprecated fields introduced in #423

Compared with the pre-#423 master (8cbdbfc7), #423 added these fields, all marked deprecated in the official OpenAPI. They are removed here:

Class	Removed field	Replacement
GenerateGroupReportRequest.GroupPreTranslateAccuracySchema	postEditingCategories	matchScoreCategories
GenerateGroupReportRequest.GroupTranslatorAccuracySchema	postEditingCategories	matchScoreCategories
GenerateGroupReportRequest.GroupTranslationCostsPostEditingByTaskSchema	excludeApprovalsForEditedTranslations, preTranslatedStringsCategorizationAdjustment	—
ReportSettingsTemplate.Config	excludeApprovalsForEditedTranslations, preTranslatedStringsCategorizationAdjustment	—

• Kept: pre-existing public fields stay in place with @Deprecated.
  • postEditingCategories in PreTranslateAccuracyGenerateReportRequest and TranslateAccuracyGenerateReportRequest.
  • Both flags in TranslationCostsPostEndingGenerateReportRequest and GenerateGroupReportRequest.GroupTranslationCostsPostEditingSchema.
  • matchScoreCategories and the other non-deprecated replacements stay.
• Fixtures: the two template response fixtures no longer contain the removed flags.

Backward compatibility

• Against the last release (1.36.0) and the pre-feat(reports): update reports API to the latest docs #423 master: no public signature was removed or changed. Match keeps its constructor and every original accessor, and gains getMatchTypeValue()/setMatchTypeValue(String).
• Against current master: the only removed members are the getters/setters of the 7 fields above. They were added by feat(reports): update reports API to the latest docs #423, which is not part of any release yet (latest tag: 1.36.0).
• Null-ambiguity: no new null-ambiguous overloads.
• Match equals/hashCode: these now compare the raw matchType string. The result is the same for every predefined value.
• JSON key order: for Match, matchType is now written after price. Key order has no meaning in JSON.

Remaining risks

• The enum stays closed: MatchType doesn't list every possible range, so getMatchType() keeps returning null for values without a constant. Callers who need those values must use getMatchTypeValue(). This is documented in the Javadoc.
• No live API test: the behaviour was checked against the OpenAPI specs and mock tests, not against the live Crowdin API.

Testing

• Reports tests: 73 passed, 0 failed.
  • New MatchTest (5 tests, using the real JacksonJsonTransformer): round trips for every MatchType constant through the enum accessors, known values parsed into the enum, custom ranges sent and parsed without loss, and enum setter/null behaviour.
  • New addPostEditingReportSettingsTemplateWithCustomMatchTypeRangesTest: a settings template with perfect, 100-82, 100-74 and 99-60 through ReportsApi, checking the request JSON and the response values.
  • The existing tests that use setMatchType(MatchType…) and their fixtures pass unchanged.
• Full build (./gradlew build): 717 tests, 0 failures, on both JDK 17 and JDK 8.
• Javadoc on JDK 8: no errors.
• Schema checks:
  • Request and response fixtures for the settings template and the group and project cost reports were validated against the OpenAPI schemas.
  • The affected classes were compared field by field with the schemas. matchType is type: string with no enum in every context, and no non-deprecated field is missing.

🤖 Generated with Claude Code