[stephankaag]

Workspace#resolve compares a path's spelling with the root. A symlink inside the workspace that leads outside it lets read and list reach whatever it points at, and write create files there. A cloned repository can bring such a link, and code run in the workspace can make one with ln -s ~/.ssh keys.

Now a path is judged by where it really leads: the part that exists, with its links resolved, then the rest, which a write would create, against the root as the file system knows it (on macOS /var is /private/var). A broken link on the way is refused, since a write would follow it anywhere. Links that stay inside keep working.

workspace = RubyLLM::Code::Workspace.new(dir)
File.symlink(Dir.home, File.join(dir, "home"))

workspace.resolve("home/.ssh/id_ed25519")
# before: "#{dir}/home/.ssh/id_ed25519", which read opens as ~/.ssh/id_ed25519
# now:    RubyLLM::Code::ToolError: home/.ssh/id_ed25519 is outside the workspace

Specs cover a file and a new file through a link that leads out, the link itself, a broken link, links that stay inside, globs leaving outside links out, new files in folders that do not exist yet, and a root reached through a link.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: crmne/ruby&#95;llm-code
• Branch: main
• File: .coderabbit.yaml
• Commit: a6ba285
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: e26cb5ef-49c8-47a1-aa45-0f7d77afff6a

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}