Skip to content

Remove request signature tag requirement - #788

Merged
timkelty merged 1 commit into
mainfrom
timkelty/remove-signature-tag-requirement
Sep 16, 2026
Merged

timkelty merged 1 commit into
mainfrom
timkelty/remove-signature-tag-requirement

Conversation

@timkelty

Copy link
Copy Markdown
Contributor

Summary

  • remove the statement that every Craft Cloud request signature must include tag="craft-cloud"
  • retain the tag in signing examples as optional identifying metadata

Testing

  • git diff --check

@timkelty
timkelty requested a review from a team as a code owner September 16, 2026 12:55
@netlify

netlify Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for craft-docs ready!

Name Link
🔨 Latest commit 0e6ab85
🔍 Latest deploy log https://app.netlify.com/projects/craft-docs/deploys/6aaa91b3669bca00075dfe11
😎 Deploy Preview https://deploy-preview-788--craft-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T12:56:56.801095Z 0e6ab85 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@timkelty
timkelty merged commit bf6947c into main Sep 16, 2026
9 checks passed
@timkelty
timkelty deleted the timkelty/remove-signature-tag-requirement branch September 16, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant