Skip to content

Require observed flag checks for auto-validated crackmes - #197

Closed
xusheng6 wants to merge 1 commit into
crackmesone:mainfrom
xusheng6:codex/verify-crackme-flags
Closed

xusheng6 wants to merge 1 commit into
crackmesone:mainfrom
xusheng6:codex/verify-crackme-flags

Conversation

@xusheng6

@xusheng6 xusheng6 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Require uploaders to enter the flag they observed from the submitted file and verify it matches the auto-validation flag in CMO format.
  • Require reviewers to independently enter the observed flag before approval, and require the same check when an admin changes a flag or replaces a flagged file.
  • Preserve the entered value after a rejected upload and document the upload requirement.

Verification

  • .venv/bin/python -m pytest -q tests/test_solves.py tests/test_reviewer_operations.py (78 passed)
  • git diff --check

The check relies on the uploader and reviewer actually running or inspecting the challenge. It does not execute arbitrary uploaded files on the server.

@xusheng6

Copy link
Copy Markdown
Contributor Author

Close as not needed -- the website already checks the flag for initial upload, review, and crackme edits. The flag cannot be possibly set to a wrong format.

What happened was that a user accidentally made a crackme that accepts a flag in the style Flag{xxxx}, which is in the wrong format. He still set sth to the right format on the website, i.e., CMO{xxxx} (which I do not know the exact value), but that does not work. It should have been rejected during review

@xusheng6 xusheng6 closed this Oct 16, 2026
@xusheng6
xusheng6 deleted the codex/verify-crackme-flags branch October 16, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant