[2bndy5]

resolves #500

This new --gen-patch arg can be set using cpp-linter v1's --fix arg.

All this does is skip generating a patch file with applied fixes.
This is more performant when not posting PR reviews and no generated patch file is desired.

clang-tidy and clang-format still make changes in cache to create feedback. But the cached changes are not used to create a single patch file.

Summary by CodeRabbit

New Features

• Added optional patch generation through --gen-patch and --fix.
• Generated patch files are cached and displayed only when enabled.
• Feedback reports the location of generated patch files.

Bug Fixes

• Formatting and lint fixes no longer create patch files when patch generation is disabled.
• Code review workflows continue generating patches as expected.

Tests

• Added coverage for patch-enabled and patch-disabled workflows, including cross-file fixes and patch output.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.43%. Comparing base (b38715f) to head (e159c8d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #511   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          28       28           
  Lines        6691     6774   +83     
=======================================
+ Hits         6653     6736   +83     
  Misses         38       38           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Essentials
• Run ID: 54585f3b-a796-448b-9b61-6c36f5c87eed

📥 Commits

Reviewing files that changed from the base of the PR and between b38715f and e159c8d.

📒 Files selected for processing: 9

• cpp-linter/src/clang_tools/clang_format.rs
• cpp-linter/src/clang_tools/clang_tidy/mod.rs
• cpp-linter/src/clang_tools/clang_tidy/other_files/mod.rs
• cpp-linter/src/clang_tools/clang_tidy/other_files/test.rs
• cpp-linter/src/clang_tools/clang_tidy/test.rs
• cpp-linter/src/cli/mod.rs
• cpp-linter/src/cli/structs.rs
• cpp-linter/src/rest_client.rs
• cpp-linter/tests/comments.rs

📝 Walkthrough

The change adds an opt-in patch-generation option, makes clang-format and clang-tidy cache patched files only when enabled, and gates non-PR-review feedback patch generation on the option.

Changes: Patch generation

Layer / File(s)	Summary
Patch option and parameter propagation cpp-linter/src/cli/mod.rs, cpp-linter/src/cli/structs.rs	The CLI adds --gen-patch, with --fix as an alias and a false default. Parameter conversions propagate the option and enable clang patch generation for PR reviews.
Conditional clang patch caching cpp-linter/src/clang_tools/clang_format.rs, cpp-linter/src/clang_tools/clang_tidy/*	Clang-format and clang-tidy cache patched files only when patch generation is enabled. Tests cover disabled patch generation and cache-writing cases.
Feedback patch output cpp-linter/src/rest_client.rs, cpp-linter/tests/comments.rs	Non-PR-review feedback generates a patch only when the option is enabled. The integration tests pass the option through the CLI and validate patch output when enabled.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to 7969b

Tidy feedback may refer to a patch that was not generated. This bounded messaging risk does not appear to block merging.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the main change: adding --fix as an alias for the new --gen-patch/-F option.
Linked Issues check		Issue #500 requires a way to generate a fixes patch without enabling --pr-review. The PR adds FeedbackOptions::gen_patch with --fix as an alias, propagates the setting through FeedbackInput an…
Out of Scope Changes check		The changed clang-format and clang-tidy cache behavior supports issue #500 by avoiding patch-file creation when patch generation is disabled. The CLI, REST-client, and test changes verify the option a…
Docstring Coverage		Docstring coverage is 86.21% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 29 functions across 9 files.

Full details: Linked Issues check

Explanation

Issue #500 requires a way to generate a fixes patch without enabling --pr-review. The PR adds FeedbackOptions::gen_patch with --fix as an alias, propagates the setting through FeedbackInput and ClangParams, and enables patch generation when either gen_patch or pr_review is active. The changes also retain test coverage for generated patches and for the disabled case.

Full details: Out of Scope Changes check

Explanation

The changed clang-format and clang-tidy cache behavior supports issue #500 by avoiding patch-file creation when patch generation is disabled. The CLI, REST-client, and test changes verify the option and its patch-generation behavior. No unrelated change is established by the available PR summary.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[2bndy5]

The latest benchmark CI results (on this branch) show v2 wall time about the same as v1 (neglible difference). Note, benchmark does not apply any fixes, only shows clang-tool results (as if triggered by push event), and disables lines/files-changed-only features.

I'm not sure how much more performance we can squeeze out of this v2 implementation.