Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
PR Summary by QodoInstall Git from containerbase prebuild releases
AI Description
Diagram
High-Level Assessment
Files changed (18)
|
Code Review by Qodo
1. Java arm64 image skips Git coverage
|
1147a4d to
2444cf9
Compare
2444cf9 to
5fc0406
Compare
|
/review |
5fc0406 to
228b1a8
Compare
228b1a8 to
b10f970
Compare
b10f970 to
754f283
Compare
Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
754f283 to
725fe85
Compare
| # renovate: datasource=github-releases packageName=containerbase/git-prebuild | ||
| RUN install-tool git 2.56.0 |
There was a problem hiding this comment.
1. Java arm64 image skips git coverage 📘 Rule violation ▣ Testability
The Java amd64 fixture now installs Git at test/java/Dockerfile:24, but its matching arm64 fixture has no corresponding install-tool git step. Arm64 Java images therefore do not exercise the changed Git installer, leaving that supported architecture untested.
Agent Prompt
## Issue description
The Java test suite now exercises the Git installer only on amd64, while the matching arm64 Dockerfile has no Git installation test.
## Fix Focus Areas
- test/java/Dockerfile.arm64[20-24]
- test/java/Dockerfile[23-24]
## Recommended Fix
Add the same Renovate annotation and literal `RUN install-tool git 2.56.0` command to `test/java/Dockerfile.arm64`, keeping the amd64 and arm64 fixtures consistent.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| # renovate: datasource=github-releases packageName=containerbase/git-prebuild | ||
| RUN install-tool git 2.56.0 |
There was a problem hiding this comment.
2. Swift arm64 image skips git coverage 📘 Rule violation ▣ Testability
The Swift amd64 fixture now installs Git at test/swift/Dockerfile:24, but its matching arm64 fixture has no corresponding install-tool git step. Arm64 Swift images therefore do not exercise the changed Git installer, leaving that supported architecture untested.
Agent Prompt
## Issue description
The Swift test suite now exercises the Git installer only on amd64, while the matching arm64 Dockerfile has no Git installation test.
## Fix Focus Areas
- test/swift/Dockerfile.arm64[20-24]
- test/swift/Dockerfile[23-24]
## Recommended Fix
Add the same Renovate annotation and literal `RUN install-tool git 2.56.0` command to `test/swift/Dockerfile.arm64`, keeping the amd64 and arm64 fixtures consistent.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Changes
install-tool gitinstalls git from the containerbase/git-prebuild releases instead of the git-core PPA:.sha512git,git-receive-pack,git-shell,git-upload-archive,git-upload-pack,scalar) instead of the shell wrapper, so signals (e.g. Renovate's git timeout) reach git and its environment isn't changedperl,liberror-perl,git-man, gnutls libcurl) are still installed (Stop installing git's former Ubuntu dependencies #7821), and the binaries are also linked in/usr/bin(Remove the git compatibility links in /usr/bin #7822)needsRoot,/etc/gitconfigandsafe.directory '*'stay; container tests check the links, version, system config origin, https clone and git-lfsContext
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Code, tests and docs written with Claude Code (Claude Opus 5.5).
Use of AI in replying to PR comments
Who answers review comments:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
🤖 Generated with Claude Code