Skip to content

Update FullSend workflow pins - #3628

Merged
st3penta merged 1 commit into
conforma:mainfrom
st3penta:fix/fullsend-app-set-forwarding
Oct 22, 2026
Merged

st3penta merged 1 commit into
conforma:mainfrom
st3penta:fix/fullsend-app-set-forwarding

Conversation

@st3penta

Copy link
Copy Markdown
Contributor

What:

Update both FullSend reusable workflow pins to
0b21529c6768d9b5ec47b16994a08db83b1d406a.

Why:

The pinned dispatcher does not pass FULLSEND_APP_SET to the review
runner. The current review harness is pinned to an older revision, but
this prepares the runner for the newer harness mapping.

Tickets:

None.

Co-Authored-By: gpt-6-luna noreply@openai.com

#### What:
Update both FullSend reusable workflow pins to
`0b21529c6768d9b5ec47b16994a08db83b1d406a`.

#### Why:
The pinned dispatcher does not pass `FULLSEND_APP_SET` to the review
runner. The current review harness is pinned to an older revision, but
this prepares the runner for the newer harness mapping.

#### Tickets:
None.

Co-Authored-By: gpt-6-luna <noreply@openai.com>
@st3penta
st3penta requested a review from a team as a code owner October 21, 2026 14:42
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: eec10edb-8f12-4886-aed3-f43ec97058cc
📥 Commits

Reviewing files that changed from the base of the PR and between be22fc0 and 0e34d36.

📒 Files selected for processing: 2
  • .github/workflows/fullsend.yaml
  • .github/workflows/prioritize.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📝 Walkthrough

Two GitHub Actions workflows now reference reusable workflows at commit 0b21529c6768d9b5ec47b16994a08db83b1d406a.

Changes: Reusable workflow revision pins

Layer / File(s) Summary
Update reusable workflow references
.github/workflows/fullsend.yaml, .github/workflows/prioritize.yml
Both workflows now reference reusable workflows at commit 0b21529c6768d9b5ec47b16994a08db83b1d406a.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: jsmid1, robnester-rh

Merge Risk: ⚪ Minimal · up to 0e34d

The workflow pin updates are ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: updating the FullSend workflow pins.
Description check Passed The description includes all required sections: What, Why, and Tickets. It explains the pin updates and their purpose. It also states that no ticket applies.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 21, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Tiny 4-line pin update to two CI workflow files; PROTECTED_PATH_COUNT=2 and CI_WORKFLOW_CHANGED drive Tier 1 above baseline, while moderate 30-day churn and fix-commit history on both files push Tier 2 to 3, yielding a composite of ~2.4 rounded to moderate.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] .github/workflows/fullsend.yaml — This file is under the protected path .github/. Governance and infrastructure files require human approval, and this PR has no linked issue (PR body says "Tickets: None."), so there is no issue-level authorization record for touching workflow configuration.
    Remediation: Link to (or create) an issue that authorizes the FullSend dispatcher pin bump and justifies modifying .github/workflows/. Human approval is required regardless of context.

  • [protected-path] .github/workflows/prioritize.yml — This file is under the protected path .github/. Governance and infrastructure files require human approval, and this PR has no linked issue (PR body says "Tickets: None."), so there is no issue-level authorization record for touching workflow configuration.
    Remediation: Link to (or create) an issue that authorizes the FullSend prioritize-workflow pin bump and justifies modifying .github/workflows/. Human approval is required regardless of context.


Labels: PR modifies GitHub Actions workflow configuration under .github/workflows/


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread .github/workflows/fullsend.yaml
Comment thread .github/workflows/prioritize.yml
@fullsend-ai-review fullsend-ai-review Bot added the github_actions Pull requests that update GitHub Actions code label Oct 21, 2026
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.54% <ø> (ø)
generative 12.25% <ø> (ø)
integration 23.55% <ø> (ø)
unit 72.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robnester-rh robnester-rh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st3penta
st3penta merged commit 1976246 into conforma:main Oct 22, 2026
89 checks passed
@st3penta
st3penta deleted the fix/fullsend-app-set-forwarding branch October 22, 2026 08:53
@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #3628 — Update FullSend workflow pins

Outcome: The workflow completed successfully. The review agent ran, posted findings, and the PR was merged after three human approvals. No new proposals are warranted — all improvement opportunities are covered by existing open issues.

What happened

PR #3628 is a 4-line mechanical SHA pin bump updating two .github/workflows/ files (fullsend.yaml and prioritize.yml) from one fullsend reusable workflow revision to another. The review agent (run 39619239397) correctly classified the scope as "trivial" (mechanical SHA pin update), but still dispatched 5 sub-agents (correctness, security, intent-coherence, style-conventions, risk-assessment) plus a challenger sub-agent, taking ~10 minutes and costing $3.46.

The review issued request-changes based on 2 high-severity protected-path findings (both files under .github/ with no linked issue). The review was DISMISSED, and three human reviewers approved without substantive concern — appropriate for a mechanical infrastructure pin change.

Judge scores

  • 3/5 — Full sub-agent fleet dispatched for trivial-scoped change — summary-only; directly covered by agents#301, fullsend#4060, fullsend#3240. This PR provides additional evidence: the agent classified the change as trivial but still ran the full review pipeline at $3.46.
  • 3/5 — Protected-path high severity on mechanical pin bump — summary-only; directly covered by fullsend#5370, agents#741, agents#1616. The protected-path findings added no safety value for a workflow pin bump and were overridden by all three human reviewers.
  • 3/5 — request-changes verdict on unambiguously safe change — summary-only; a consequence of the above two gaps. The review was DISMISSED, indicating the verdict was a false positive.
  • 2/5 — Skip review entirely for fullsend version bump PRs — summary-only; exactly covered by fullsend#7357.
  • 1/5 — Redundant pull_request_review workflow triggers — summary-only; 4 additional workflow runs were triggered by human review events, but routing correctly skipped all agent jobs. Minimal overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code risk/moderate PR risk: moderate size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants