Repository navigation
ci: adopt the shared CI - #486
Merged
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gusfcarvalho
previously approved these changes
Oct 9, 2026
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Merged
gusfcarvalho
approved these changes
Oct 9, 2026
gusfcarvalho
pushed a commit
that referenced
this pull request
Oct 9, 2026
Task: W1-S2-T02 Part 2 of 3 of the api onboarding stack ([CCF Release Automation Design](https://claude.ai/code/artifact/39df6ba0-8484-4b08-bfc4-962357843585)). Stacked on #486. Adds release-please, run as ccf-release-bot by the shared `release-please.yml` (pinned at the v1.5.0 release commit, `899dbe5`). **Removes:** no workflow files. The old tag-push `publish.yml` is replaced in the next PR of the stack. ## Changes - `release-please-config.json`: the shared `release-please/defaults.json` from workflows v1.5.0, copied verbatim (the shared workflow warns on drift), plus `bootstrap-sha` and one package `.` with release type `go`. - `.release-please-manifest.json`: seeded at `0.21.0`, the latest release. - `bootstrap-sha` is `0b0cefc` (current `main`, which is also the `v0.21.0` tag). - `.github/workflows/release-please.yml`: runs on pushes to `main`, `secrets: inherit` (the ccf-release-bot secrets come from the repo's `release` environment once repo-settings applies). - `ci.yml`: adds the `release-checks` job (checks release PRs only; skipped, so passing, on any other PR) and adds it to `notify`. ## Expected next version `v0.21.0` is the current `main` commit, so nothing has landed since the last release. After this stack merges, release-please sees only the onboarding commits (all of hidden types), so it opens no release PR yet. The first feature commit after that proposes `0.22.0` (a breaking change also gives `0.22.0`, since `bump-minor-pre-major` is on), and the first fix proposes `0.21.1`. None of this stack's PR bodies has a line that reads as a conventional commit, so the squash merges add no extra commits for release-please to count. ## Before this merges (human) release-please's first run on `main` needs the `release` environment secrets, so the repo-settings apply for api must come before this PR merges (W1-S2-PRE, per-repo order). ## Verified - Both JSON files parse, and the config has no keys that differ from the shared defaults. - api's `go.mod` has no compliance-framework dependencies, so `release-checks` has no final-dependency check to fail on a release PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: ccf-lisa[bot] <286799724+ccf-lisa[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: W1-S2-T01
Part 1 of 3 of the api onboarding stack (CCF Release Automation Design).
Replaces the repo's CI with a caller of the shared
ci-go-service.ymlfrom compliance-framework/workflows, pinned at the v1.5.0 release commit (899dbe5). The status check to require from now on isci / required.Removes:
.github/workflows/ci.yml(the oldCIworkflow). It is replaced in place by the newci.ymlcaller. No other workflow called it.What the new caller sets
prepare-command: make swag, so the Swagger docs are regenerated before vet, the tests and the make targets, as the old unit and integration jobs did.make-targets: test-integration check-diff.lint-timeout-minutes: 30(the old lint job ran with--timeout=30m).pull_requesttypes[opened, edited, synchronize, reopened, labeled, unlabeled, closed]and pushes tomain, as on mock-api.notifyjob callingnotify-failure.ymlwithsecrets: inherit.Test race fix
The stack also fixes a pre-existing test race that the new
-raceflag surfaced: ininternal/service/scheduler/scheduler_test.go,mockJob.Executewrote itsexecutedandexecCountfields from overlapping cron goroutines while the test read them (TestCronScheduler_StartStopfailed on #487). The fields are nowatomic.Boolandatomic.Int32, read withLoad(); no non-test code changes. Locally,go test -race -count=20 ./internal/service/scheduler/...passes with the fix and reported the race in 1 of 20 runs without it. A sweep of the other test doubles found none mutated from goroutines the code under test starts.Old jobs and where they run now
lint--timeout=30m, default lintersci / golangci-lint.golangci.yml, so the shared base config applies.unit-testsmake swagthenmake testci / gogo test -race ./...(the race detector is new), plus gofmt,go vet, ago mod tidycheck andgo build.integration-testsmake swagthenmake test-integrationci / makepostgres:17.5through testcontainers; the old job had no workflow services, and the new runner (ubuntu-latest) has Docker too. The old job took about 8 minutes; the make job's timeout is 30.check-diffmake check-diff(PRs only)ci / makemain, where the old job was skipped.ci / commonTrigger change: the old workflow also ran on pushes to
release-*branches. None exist, and from T02 on, releases are cut frommainby release-please, so the new caller runs onmainonly.Legacy required checks
The
mainruleset requiresintegration-tests,unit-testsandcheck-diff, and the classic branch protection requiresunit-tests. None of these run after this PR, so they stay pending here. A human removes the ruleset and the classic protection before the stack merges (W1-S2-PRE); this PR does not touch them.Verified
ci-go-service.ymlat v1.5.0 (prepare-command,make-targets,lint-timeout-minutes)..gitignorecoverscover.out, whichmake test-integrationwrites beforecheck-diffchecks the tree.ci.yml.ci / requiredon this PR's head is the check to read.🤖 Generated with Claude Code