Repository navigation
fix: persist spinner state so a reconnecting client sees it correctly - #57
Merged
Merged
Conversation
Outbox.send_dict previously excluded "spinner" messages from persistence alongside one-off "ui" toasts. But spinner visibility is a *state* (like camera position or background color), not a one-shot notification: if a client's WebSocket connection drops mid-load and reconnects, it needs to see the CURRENT spinner state, not silently miss the "stop" it never received while disconnected and get stuck showing a spinner forever. Workspace.start_spinner/stop_spinner now also pass a stable obj_id="spinner" so each call overwrites the same persisted slot instead of piling up as separate history entries a reconnect could replay out of order. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 23, 2026
ericgozzi
added this pull request to stack #60
September 23, 2026 06:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Outbox.send_dictskipped persisting"spinner"messages the same way it skips"ui"toasts. If a client's WebSocket dropped mid-load and reconnected, it never got the "stop" and showed the spinner forever.Workspace.start_spinner/stop_spinnerpass a stableobj_id="spinner", so each call overwrites one persisted slot instead of adding history entries that a reconnect could replay out of order.First PR in a stack of fixes: this one → #58 (WebSocket max frame size) → #59 (scale-mode
object_transform).Test plan
pytest(newtests/test_spinner_persistence.py)🤖 Generated with Claude Code