Repository navigation
Fix XY line intersections far from the origin - #1535
Open
ArianMoeini wants to merge 2 commits into
Open
ArianMoeini wants to merge 2 commits into
ArianMoeini wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1398.
intersection_line_line_xyused determinants of absolute point coordinates. For points far from the origin, it subtracted large, nearly equal products and lost precision. This change computes the intersection parameter from coordinate differences relative to the first point, then evaluates the point on the first line.The regression test uses the coordinates from #1398. Before the fix, the 2D result differed from the expected intersection by about 0.00576; after the fix, it matches within 1e-7.
What type of change is this?
Checklist
ruff checkpasses for both changed Python files; a repository-wide run reports 12 existing errors in unrelated files.Ruff format checks and
git diff --checkpass. I also added myself toAUTHORS.mdas requested byCONTRIBUTING.md.