Repository navigation
Conversation
…mment names section groups The colbymchenry#2494 entry bundled three fixes into one sentence and left a blank line that turned the whole Fixes list loose. It is now three plain-language bullets next to the other Shopify entries. The Shopify theme resolver's header comment now says the extractor also records `sections/<group>.json` for `{% sections %}`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019zFDanXAMbewuhGttMdGh5
|
Updated validation after the supplied review: Updated against main |
|
Thanks @Puma7 for #2494 and this fix. Main now handles editor-saved Shopify JSON with its leading comment, |
Shopify editor comments currently make JSON templates lose all section links; plural section-group tags are also missed. Parse these files with the existing JSONC dependency and preserve the position of each
typevalue. Comment/raw schema examples now use the same suppression scanner as ordinary tags.Closes #2494.
Validation: all 26 dedicated regressions pass, including malformed JSON, forward/reverse dependencies, multiline tags and isolation between themes. JSON syntax checking is not full Shopify schema validation. Re-index existing themes after upgrading.
Combined validation against main
80e4b459(Windows, Node 24, WASM, two workers): 6,752 passed, zero failed, 406 skipped under existing platform/kernel gates; standard timeouts unchanged. Separate active-native checks passed 152 class/parity and 112 constructor/super cases. These are local results, not GitHub CI or other-OS claims.