Repository navigation
Android phones: review fixes that missed #143 - #144
Merged
Merged
Conversation
- Saved logins on phones only for runs that may reveal secrets: what is typed on a phone can be read through its shell. Secrets go to adb on stdin (not in process arguments here), 2FA codes are masked too, the UI dump gets a fresh name each time. - android_assign only gives phones to other agents, never to the caller or its own chat. - adb stderr is capped like stdout. - Live view: video and still pictures side by side (viewers without WebCodecs watch along), stills only go to video viewers when the phone can't stream, restarts are spaced out per device (a congested viewer can't restart everyone's stream), no screenrecord left running after a stop. - Input on letterboxed video maps to the right pixel; edge pixels clamp. - pull_file refuses folders and cleans up after itself; open_app quoting; a refresh that must start adb isn't swallowed by one in flight. - Emulators nobody named, described or assigned are forgotten after a day out of sight; the page groups phones that aren't connected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last commit of #143 (be20af6, the fixes from its code review) was pushed before the merge, but GitHub never synced it into the PR, so #143 was merged without it. This brings it to main unchanged.
adb shellon stdin (not in process arguments on the computer), 2FA codes are masked too, the UI dump gets a fresh name each time.android_assignonly gives a phone to another agent, never to the caller or its own chat.pull_filerefuses folders and cleans up after itself; a refresh that must start adb isn't swallowed by one already running.Tests:
test/android.test.ts19 pass (reveal-only fills via stdin, manager self-assignment refused, letterbox mapping, folder pulls), related suites 201 pass. CI on the commit itself was green (run 38139290557).