Repository navigation
fix: show as many snippets per page as Screen Options allows - #616
Open
TallblokeUK wants to merge 3 commits into
Open
TallblokeUK wants to merge 3 commits into
TallblokeUK wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snippets list could show fewer snippets than the Snippets per page Screen Option allows, and fewer pages than there are snippets.
Changes
code_snippets/manage/inline_snippets_limitfilter still applies. Code bodies were already left out of the inline data.ListTabletakesitemsPerPageand works out the page count, instead of takingtotalPagesand dividing the items evenly across pages. With 324 snippets at 100 per page, pages now hold 100, 100, 100 and 24 rather than 81 each.PartialDataListTablekeeps its owntotalPages.test_enqueue_omits_snippets_above_inline_limitrelied on the test database holding a single snippet; it is replaced by a test that the inline list is cut to the limit.Verification
Manage_Menu_Assets_Testcase: with 110 per page and 120 snippets, 110 are sent inline.