Repository navigation
fix: test the universal search upgrade prompts without a licence on any edition - #605
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two universal search upgrade prompt tests now set the page's licence state to unlicensed before loading it, as
code-snippets-stats.spec.tsandcloud-download-eligibility.spec.tsalready do. The tests then cover the same prompts whatever the test site's edition.Changes
tests/e2e/universal-search.spec.ts: adds aforceLicenseState()helper and calls it in "without Pro, searching the Cloud Library is offered as an upgrade" and "without Pro, the Cloud Library tab of the results page offers an upgrade".Verification
tests/e2e/universal-search.spec.ts: 54 passed across the database and file-based projects.