Repository navigation
Conversation
EhabY
force-pushed
the
fix/oauth-scope-session-lifecycle
branch
from
October 9, 2026 23:05
e8d23c6 to
8125427
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1138's token-cleanup comment: clean up replaced OAuth sessions without forcing immediate re-login when required scopes change.
canRefreshOAuthSession.user:update_personalfor refreshing expired workspace external-auth links. Inbox permissions remain optional.No startup/remote admission gates, per-action permission maps, or recovery redesign. Users may encounter feature-specific permission errors before expiry; those do not automatically prompt for login.
Change size
Diff against the PR merge base; counts include moved code and rename edits.
src/**)test/**)Validation
pnpm test:extension: 2,377 passed, 6 skipped before the final persistence-only cleanup; the affected login/session suites passed again afterwards (75 tests).pnpm typecheck,pnpm lint,pnpm format:check,pnpm build, andgit diff --check: passed.xvfb-run -a pnpm test:integration: passed on VS Code 1.105.0 and 1.141.0 (activation/command smoke tests, not a live OAuth exchange).Approved narrow implementation plan
coder:allremain accepted.Server source checked on Coder main
89d9492and v2.38.0c3c6a67: token responses report granted scopes; discovery lists recognized names, not guaranteed grants; revocation targets the presented token pair, not independent replacement credentials. Older servers omit scope and grant unrestricted access.Generated by Coder Agents on behalf of @EhabY.