Skip to content

fix: apply SSH tuning settings per provider - #1146

Merged
EhabY merged 2 commits into
mainfrom
fix/ide-ssh-settings
Oct 8, 2026
Merged

EhabY merged 2 commits into
mainfrom
fix/ide-ssh-settings

Conversation

@EhabY

@EhabY EhabY commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Share provider-specific tuning between connection setup and Apply Recommended SSH Settings; unsupported providers get no tuning overrides.
  • Prefer Devin settings, with a small registered-namespace fallback for Windsurf 2.x. Preserve effective deprecated values during automatic setup.
  • Keep constants readonly and exported functions ahead of helpers. Cover automatic/recommended values in a compact provider table using the shared configuration mock.

Closes #1145.

Plan and compatibility decision

Apply only settings the selected Remote-SSH provider reads: Microsoft timeout/grace/max attempts; Cursor timeout/shutdown; Open Remote SSH timeout; Devin/Windsurf timeout/grace/max attempts. IDE branding does not affect selection. Antigravity and unrecognized providers receive no tuning overrides.

Retain the small Windsurf fallback: official release bundles confirm support in 2.0–2.3, and Devin retains migrated settings. No public version-specific usage evidence was found. Namespace detection prefers registered Devin keys over Windsurf keys.

Keep the 30-minute timeout minimum, 8-hour automatic defaults, and opt-in 24-hour recommendations. Leave platform handling, provider-selection precedence, and existing stored keys unchanged. Use table-driven coverage for provider values and focused regressions for migrated values, explicit settings, and idempotence.

Generated by Coder Agents on behalf of @EhabY.

@EhabY
EhabY force-pushed the fix/ide-ssh-settings branch 2 times, most recently from 301f257 to e6a6b10 Compare October 8, 2026 12:44
@EhabY
EhabY force-pushed the fix/ide-ssh-settings branch from e6a6b10 to 63c4bbe Compare October 8, 2026 14:06
Comment thread src/remote/sshOverrides.ts
Comment thread src/remote/sshOverrides.ts Outdated
Comment thread src/remote/sshOverrides.ts Outdated
Enable oxlint's no-implicit-coercion so `!!x`, `+x` and `"" + x` are
flagged in favour of explicit Boolean/Number/String conversions.
@EhabY
EhabY merged commit d3fdc6c into main Oct 8, 2026
13 checks passed
@EhabY
EhabY deleted the fix/ide-ssh-settings branch October 8, 2026 18:05
@EhabY EhabY mentioned this pull request Oct 12, 2026
EhabY added a commit that referenced this pull request Oct 13, 2026
Bump package.json to 1.17.0 and cut the changelog's Unreleased section as
v1.17.0. Merge the two Fixed sections into one, and add the missing
entries for session app names (#1136), SSH tuning per provider (#1146),
and Windows include escaping (#1131).
EhabY added a commit that referenced this pull request Oct 13, 2026
Bump package.json to 1.17.0 and cut the changelog's Unreleased section as
v1.17.0. Merge the two Fixed sections into one, and add the missing
entries for session app names (#1136), SSH tuning per provider (#1146),
and Windows include escaping (#1131).
EhabY added a commit that referenced this pull request Oct 13, 2026
Bump package.json to 1.17.0 and cut the changelog's Unreleased section as
v1.17.0. Merge the two Fixed sections into one, group the OAuth entries,
and add the missing entries for session app names (#1136), SSH tuning per
provider (#1146), and Windows include escaping (#1131).
EhabY added a commit that referenced this pull request Oct 13, 2026
Bump package.json to 1.17.0 and cut the changelog's Unreleased section as
v1.17.0. Merge the two Fixed sections into one, group the OAuth entries,
and add the missing entries for session app names (#1136), SSH tuning per
provider (#1146), and Windows include escaping (#1131).
EhabY added a commit that referenced this pull request Oct 13, 2026
Bump package.json to 1.17.0 and cut the changelog's Unreleased section as
v1.17.0. Merge the two Fixed sections into one, group the OAuth entries,
and add the missing entries for session app names (#1136), SSH tuning per
provider (#1146), and Windows include escaping (#1131).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply SSH reconnection settings on Devin Desktop (Windsurf)

2 participants