Repository navigation
isMaxLengthSupported() answered "supported" when the platform imposed no limit - #5670
Merged
Merged
Conversation
… no limit
The predicate guarded on the RESOLVED length where its three siblings guard on
the PREFERRED one:
isQualitySupported() preferredQuality == 0 || quality == preferredQuality
isMaxFileSizeSupported() preferredMaxFileSize == 0 || maxFileSize == preferredMaxFileSize
isSizeSupported() preferredWidth == 0 && preferredHeight == 0
isMaxLengthSupported() maxLength == 0 || maxLength == preferredMaxLength
The intent of that first clause is "the caller asked for no constraint, so any
resolved value satisfies it". Reading it off the resolved field makes it fire in
the opposite situation: a platform that expresses "no duration limit" by
resolving maxLength to 0 -- which is every platform with no compiler registered,
Java SE included, and any compiler that declines the request -- turned a
five-second preference into isMaxLengthSupported() == true, and isSupported()
with it. A caller asking whether its limit would be honored was told yes
precisely when the answer was no.
That also broke the invariant getMaxLength() documents: "This value will be
equal to getPreferredMaxLength() iff isMaxLengthSupported() is true."
When the caller asked for no limit, preferredMaxLength and maxLength are both 0,
so the new clause covers that case identically. The clause only ever changed the
answer in the broken case.
No framework caller reads the predicate, and no test asserted the old behaviour,
so nothing depended on it. The developer guide's Video-Capture-Constraints
example already describes the fixed semantics, and its support table already
lists Java SE as having no max-length support.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Compared 151 screenshots: 151 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Contributor
Cloudflare Preview
|
Collaborator
Author
|
Compared 181 screenshots: 181 matched. |
Collaborator
Author
|
Compared 148 screenshots: 148 matched. Benchmark Results
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 160 screenshots: 160 matched. Benchmark Results
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 143 screenshots: 143 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 144 screenshots: 144 matched. |
Collaborator
Author
|
Compared 149 screenshots: 149 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 217 screenshots: 217 matched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VideoCaptureConstraints.isMaxLengthSupported()guarded on the resolved length where its three siblings guard on the preferred one:isQualitySupported()preferredQuality == 0isMaxFileSizeSupported()preferredMaxFileSize == 0isSizeSupported()preferredWidth == 0 && preferredHeight == 0isMaxLengthSupported()maxLength == 0That clause means "the caller asked for no constraint, so any resolved value satisfies it". Read off the resolved field it fires in the opposite situation instead: a platform that expresses no duration limit by resolving
maxLengthto 0 — every platform with no compiler registered, Java SE included, plus any compiler that declines the request — turned a five-second preference intoisMaxLengthSupported() == true, andisSupported()with it. A caller asking whether its limit would be honored was told yes precisely when the answer was no.It also broke the invariant
getMaxLength()documents: "This value will be equal togetPreferredMaxLength()iffisMaxLengthSupported()is true."When the caller genuinely asked for no limit,
preferredMaxLengthandmaxLengthare both 0, so the new clause covers that case identically. The clause only ever changed the answer in the broken case.Blast radius
No framework caller reads the predicate (the only references are the developer guide's snippet and a generated reflection shim), and no test asserted the old behaviour, so nothing depended on it.
Verification
testMaxLengthUnsupportedWhenResolvedToZerofails on the unfixed code (expected: <false> but was: <true>) and passes after — the other two new cases pass either way, which is what isolates the defect to this one clause.core-unittestssuite: 6077 tests, 0 failures.core-unittests: report regenerated, 0 findings.Found by Codex review on #5664, where the guide chapter documents this API.
🤖 Generated with Claude Code