Repository navigation
ci: add GitHub Actions for fmt, clippy, check, and tests - #2
Merged
Merged
Conversation
Workspace members drop tmp-agent so cargo can load without a sibling antigravity-sdk-rust checkout. Unit tests are --lib --bins. Integration is the four e2e tiers on tmp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Main had no CI. Local quality gates were manual and
cargo --workspacecould not even load becausetmp-agentdepends on a missing sibling SDK.What
GitHub Actions on push to
mainand on pull requests:cargo fmt --all -- --checkcargo check --workspace --locked --all-targets --all-featurescargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --locked --lib --binse2e_tier1throughe2e_tier4as a matrixrust-toolchain.tomlpins stable plus rustfmt and clippy.make ciruns the same commands locally.crates/tmp-agentis no longer a workspace member. Cargo cannot load a workspace whose member path-depends on../../../antigravity-sdk-rustwhen that tree is absent. The crate stays in the repo.Verification
Ran locally:
cargo fmt --all -- --checkcargo check --workspace --locked --all-targets --all-featurescargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --locked --lib --bins(188 passed)cargo test -p tmp --locked --test e2e_tier1 --test e2e_tier2 --test e2e_tier3 --test e2e_tier4(114 passed)