Problem
Loading rows through a model with casts, especially as entities, repeats the same work on every row and every field:
DataCaster::castAs() parses the type string on every cast. For each value it runs str_starts_with, a match, a preg_match(), explode/array_map(trim) and a trim, all to turn something like '?int' or 'json-array' into a handler key and params. The handler itself often costs less than the parsing.
DataConverter::reconstruct() calls syncOriginal() twice for each entity. It calls injectRawData(), which already calls syncOriginal(), and then calls syncOriginal() again. When attributes hold arrays or objects, each sync normalizes them and runs json_encode().
Entity::__get() and __set() rebuild the getter or setter name on every access. They run str_replace/ucwords, then make two method_exists() calls. toArray() repeats this for every key.
Measurements
PHP 8.3 on macOS, OPcache on, production mode, warm. The test entity has 10 columns, 6 casts (int, ?int, bool, json-array, float, int-bool) and the default $dates.
| Case |
Time |
1000 rows → arrays (fromDataSource) |
3.2 ms |
1000 rows → entities (reconstruct) |
6.3 ms |
| 1000 rows → entity with no casts |
2.0 ms |
| Step |
Cost |
castAs() for an int field |
0.33 µs |
IntegerCast::get() called directly |
0.07 µs |
syncOriginal() with an array attribute |
1.2 µs per call |
Getter-name build + 2× method_exists() |
~0.1–0.2 µs per access |
__get() on a plain field |
0.46–0.58 µs |
toArray() with 10 keys |
7.6–11 µs |
Proposal
1. Cache parsed cast types (DataCaster)
Add a private static cache keyed by the type string. It stores only the parsed result: base type, params and the nullable flag.
- Handlers are not cached. Each instance still looks up the handler in its own
$castHandlers, so instances with different custom handlers keep working.
- The non-strict
'nullable' param is still added after the cache lookup.
- An unknown type still throws on every call.
- Why static: each entity has its own
DataCaster, so a per-instance cache would rarely get a hit. The parse depends only on the string, so the cache is safe across Worker Mode requests. It also can't grow without limit, because type strings come from code, not from input.
2. Sync originals once (DataConverter::reconstruct())
Remove the second syncOriginal() call. injectRawData() already syncs.
3. Per-class getter/setter map (Entity)
On the first access, build a map of each entity class's get*, _get*, set* and _set* methods using ReflectionClass::getMethods(), with lowercase keys. Lookups then replace the two method_exists() calls.
- Bounded memory: the map depends on the class, not on input. Keys passed to
fill() from request data can't make it grow.
- Same lookup rules: lowercase keys match PHP's case-insensitive method names. Reflection includes private methods, so results match
method_exists() exactly.
Estimated gains
Fixes 1 and 2 bring 1000 entities from about 6.3 ms to about 3.6 ms, roughly 40% faster. Array results drop from about 3.2 ms to about 1.7 ms. Fix 3 removes about 25–35% of the cost of each __get()/__set() call, which matters most in toArray() and in views that read many properties.
These are estimates from micro-benchmarks, not from the final code.
Behavior changes (4.8)
Only fix 2 changes behavior. If an app entity overrides injectRawData() without calling syncOriginal(), reconstruct() no longer syncs for it. Such an entity will report every field as changed after a find(), and save() will write all columns. That override is already broken for any other caller of injectRawData(). This will be listed in the v4.8.0 changelog under "Behavior Changes", with a note in upgrade_480.rst saying overrides must call syncOriginal().
Fixes 1 and 3 change no behavior.
Not changing
- Lazy
DataCaster creation in the Entity constructor (~5%). Subclasses can read the protected $dataCaster property directly and would get null.
- The non-strict
is_subclass_of() checks and the toArray() filter closure. Each costs under 2%.
Plan
One PR with three commits, one per fix. Fix 2 also includes the changelog and upgrade-guide entries.
Tests
DataCasterTest:
- Two instances with the same type string but different custom handlers each call their own handler.
- Non-strict
?type still adds nullable, and strict mode doesn't.
- An unknown type throws on every call.
DataConverterTest:
- A reconstructed entity reports
hasChanged() === false.
- An entity that overrides
injectRawData() without syncing now reports changes. This test documents the behavior change.
EntityTest:
- Getter lookup ignores case.
_getX wins over getX.
- Inherited getters are found.
- A private getter behaves as it does today.
- Maps are kept separate for each class.
Related
Problem
Loading rows through a model with casts, especially as entities, repeats the same work on every row and every field:
DataCaster::castAs()parses the type string on every cast. For each value it runsstr_starts_with, amatch, apreg_match(),explode/array_map(trim)and atrim, all to turn something like'?int'or'json-array'into a handler key and params. The handler itself often costs less than the parsing.DataConverter::reconstruct()callssyncOriginal()twice for each entity. It callsinjectRawData(), which already callssyncOriginal(), and then callssyncOriginal()again. When attributes hold arrays or objects, each sync normalizes them and runsjson_encode().Entity::__get()and__set()rebuild the getter or setter name on every access. They runstr_replace/ucwords, then make twomethod_exists()calls.toArray()repeats this for every key.Measurements
PHP 8.3 on macOS, OPcache on, production mode, warm. The test entity has 10 columns, 6 casts (
int,?int,bool,json-array,float,int-bool) and the default$dates.fromDataSource)reconstruct)castAs()for anintfieldIntegerCast::get()called directlysyncOriginal()with an array attributemethod_exists()__get()on a plain fieldtoArray()with 10 keysProposal
1. Cache parsed cast types (
DataCaster)Add a private static cache keyed by the type string. It stores only the parsed result: base type, params and the nullable flag.
$castHandlers, so instances with different custom handlers keep working.'nullable'param is still added after the cache lookup.DataCaster, so a per-instance cache would rarely get a hit. The parse depends only on the string, so the cache is safe across Worker Mode requests. It also can't grow without limit, because type strings come from code, not from input.2. Sync originals once (
DataConverter::reconstruct())Remove the second
syncOriginal()call.injectRawData()already syncs.3. Per-class getter/setter map (
Entity)On the first access, build a map of each entity class's
get*,_get*,set*and_set*methods usingReflectionClass::getMethods(), with lowercase keys. Lookups then replace the twomethod_exists()calls.fill()from request data can't make it grow.method_exists()exactly.Estimated gains
Fixes 1 and 2 bring 1000 entities from about 6.3 ms to about 3.6 ms, roughly 40% faster. Array results drop from about 3.2 ms to about 1.7 ms. Fix 3 removes about 25–35% of the cost of each
__get()/__set()call, which matters most intoArray()and in views that read many properties.These are estimates from micro-benchmarks, not from the final code.
Behavior changes (4.8)
Only fix 2 changes behavior. If an app entity overrides
injectRawData()without callingsyncOriginal(),reconstruct()no longer syncs for it. Such an entity will report every field as changed after afind(), andsave()will write all columns. That override is already broken for any other caller ofinjectRawData(). This will be listed in thev4.8.0changelog under "Behavior Changes", with a note inupgrade_480.rstsaying overrides must callsyncOriginal().Fixes 1 and 3 change no behavior.
Not changing
DataCastercreation in theEntityconstructor (~5%). Subclasses can read the protected$dataCasterproperty directly and would getnull.is_subclass_of()checks and thetoArray()filter closure. Each costs under 2%.Plan
One PR with three commits, one per fix. Fix 2 also includes the changelog and upgrade-guide entries.
Tests
DataCasterTest:?typestill addsnullable, and strict mode doesn't.DataConverterTest:hasChanged() === false.injectRawData()without syncing now reports changes. This test documents the behavior change.EntityTest:_getXwins overgetX.Related
Config/Filters.phpon every request #10616, perf: skip redundant work inRouteCollection::create()during route registration #10617