refactor: convert option-hash parameters to keyword arguments

.rubocop.yml

@@ -55,6 +55,9 @@ Style/ClassAndModuleChildren:
 Style/OptionalBooleanParameter:
   Enabled: false
 
+Style/OptionHash:
+  Enabled: true
+
 Rails/Date:
   Enabled: true
 

app/controllers/admin/events_controller.rb

@@ -90,7 +90,7 @@ def organiser_ids
     params[:event][:organisers]
   end
 
-  def grant_organiser_access(organiser_ids = [])
+  def grant_organiser_access(organiser_ids)
     organiser_ids.each { |id| Member.find(id).add_role(:organiser, @event) }
   end
 

app/controllers/admin/meetings_controller.rb

@@ -76,7 +76,7 @@ def chapter_ids
     params[:meeting][:chapters]
   end
 
-  def grant_organiser_access(organiser_ids = [])
+  def grant_organiser_access(organiser_ids)
     organiser_ids.each { |id| Member.find(id).add_role(:organiser, @meeting) }
   end
 

app/controllers/admin/sponsors_controller.rb

@@ -6,7 +6,7 @@ def index
 
     @chapters = Chapter.all
 
-    @sponsors_search = SponsorsSearch.new(search_params)
+    @sponsors_search = SponsorsSearch.new(**search_params)
     sponsors = @sponsors_search.call
     @pagy, paginated_sponsors = pagy(sponsors)
 

app/controllers/admin/workshops_controller.rb

@@ -248,7 +248,7 @@ def organiser_ids
     params[:workshop][:organisers]
   end
 
-  def grant_organiser_access(organiser_ids = [])
+  def grant_organiser_access(organiser_ids)
     organiser_ids.each { |id| Member.find(id).add_role(:organiser, @workshop) }
   end
 

app/queries/sponsors_search.rb

@@ -3,9 +3,9 @@ class SponsorsSearch
 
   attr_accessor :name, :chapter
 
-  def initialize(params = {})
-    @name = params.fetch(:name)
-    @chapter = params.fetch(:chapter)
+  def initialize(name:, chapter:)
+    @name = name
+    @chapter = chapter
   end
 
   def call

lib/verifier.rb

@@ -3,9 +3,11 @@
 class Verifier
   attr_reader :id, :token
 
-  def initialize(hash)
-    @id = hash.fetch(:id) { nil }
-    @token = hash.fetch(:token) { nil }
+  def initialize(id: nil, token: nil)
+    raise ArgumentError, 'id or token is required' if id.nil? && token.nil?
+
+    @id = id
+    @token = token
   end
 
   def access_token

spec/queries/sponsors_search_spec.rb

@@ -2,7 +2,7 @@
 
 RSpec.describe SponsorsSearch do
   describe 'initialization' do
-    it 'configures its properties from the param hash' do
+    it 'configures its properties from keyword arguments' do
       search = described_class.new(name: 'Acme', chapter: 'London')
 
       expect(search.name).to eq('Acme')