Repository navigation
fix(console): refresh agent list and reselect after rename - #375
Merged
Merged
Conversation
codeaholicguy
force-pushed
the
fix/console-rename-refresh
branch
from
October 14, 2026 14:05
17f8885 to
9258b69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause:
useRenameAgentPanehandled a successful rename by closing the pane and showing a transient message, but never called the console'srefresh()and never updated selection. Once the daemon event stream subscription succeeds,useAgentListrelaxes its 3s poll to a 60s fallback — and a registry-only rename emits no daemon event — so the list showed the old name for up to a minute and selection fell back when the refresh finally arrived.Fix: the hook now accepts
refreshand aselectAgentcallback (wired inConsoleApptouseConsoleAgentContext().refreshandsetSelectedName). On success it closes the pane, shows the transient message, awaitsrefresh(), then selectsvalues.newName— mirroringuseStartAgentPane's ordering. Failed renames keep the existing inline-error behavior with no refresh or selection change.Validation
refresh()thenselectAgent(newName)run only after a successful rename, and that a failed rename triggers neither.ConsoleProviderwith a mocked manager and verify the visible list shows the new name and selection follows — both with no daemon and with an active daemon subscription (relaxed 60s poll).npx vitest run src/__tests__/tui/console— 26 files, 218 tests passed.npm run lint— clean (pre-existing warnings only).npm test— all 8 nx projects passed.npm run test:e2e— 42 tests passed.Test plan
Closes #374
Generated with Devin