Update collector metrics - #33
Merged
Merged
Conversation
Signed-off-by: Nick Lathe <nick.lathe@code.org>
There was a problem hiding this comment.
🟢 Approval recommended
The configuration is internally consistent; only non-blocking maintenance documentation needs clarification.
Pull request overview
Expands Kubernetes monitoring metrics available to AMP and downstream Grafana dashboards.
Changes:
- Adds node, pod, rollout, HPA, throttling, OOM, and kubelet metrics.
- Refines cgroup filtering while preserving whole-node usage.
- Updates documentation and bumps the chart version.
File summaries
| File | Description |
|---|---|
apps/monitoring/README.md |
Documents expanded metric coverage. |
apps/monitoring/chart/values.yaml |
Configures collectors, metrics, and node-pool labels. |
apps/monitoring/chart/files/config.alloy |
Updates metric and label filtering. |
apps/monitoring/chart/Chart.yaml |
Bumps chart version to 0.1.3. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+24
to
+27
| The Alloy keep-list and the kube-state-metrics allowlist are the contract with | ||
| the Grafana dashboards in the `infrastructure` repo | ||
| (`observability/dashboards/grafana/src/dashboards/kubernetes/`). Add a metric to | ||
| both when a panel needs it; drop it from both when nothing reads it. |
carl-codeorg
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Lathe nick.lathe@code.org