Repository navigation
Register RegisterWaiter only through AddSignalWait (4.4.1) - #228
Merged
Merged
Conversation
AddConductorSharpPatterns() and AddCSharpLambdaTasks() scan the whole Patterns assembly with MediatR, which also picked up the RegisterWaiter handler. Its ISignalStore dependency is only registered by AddSignalWait, so projects that don't use SignalWait failed DI validation at startup. Both scans now exclude RegisterWaiter; AddSignalWait still registers it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since 4.0.0, an app that calls
AddConductorSharpPatterns()orAddCSharpLambdaTasks()but notAddSignalWait<T>()fails at startup when DI validation is on:Both methods register MediatR handlers by scanning the whole Patterns assembly, and that scan also picks up
RegisterWaiter. ItsISignalStoredependency is only registered byAddSignalWait.Change
AddConductorSharpPatterns()andAddCSharpLambdaTasks()scan with a MediatRTypeEvaluatorthat excludesRegisterWaiter.AddSignalWait<T>()is unchanged and still registers the handler, in either call order.AddSignalWait.Tests
New
PatternsRegistrationTestsbuild the provider withValidateOnBuild:RegisterWaiteris not registered. This test fails onmasterwith the error above.AddSignalWait, called before or after the other two, theRegisterWaiterhandler is registered and validation passes.dotnet test: 73/73 passed.3.x has no SignalWait, so no backport is needed.
🤖 Generated with Claude Code