Repository navigation
fix: update Perses dashboard annotation to label in alerts - #1370
Merged
Merged
Conversation
- Changed the documentation in values.yaml for cortex-nova and cortex-placement-shim to reflect that the Perses dashboard link is emitted as a label instead of an annotation. - Updated the alerts.yaml files in cortex-placement-shim to use the new `persesDashboard` label format for alert definitions, ensuring consistency with the updated values.yaml documentation. Signed-off-by: Markus Wieland <markus.wieland@sap.com>
Contributor
Test Coverage ReportTest Coverage 📊: 71.4% |
SoWieMarkus
marked this pull request as ready for review
October 19, 2026 09:27
SoWieMarkus
requested review from
PhilippMatthes,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
October 19, 2026 09:27
mblos
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
persesDashboardlabel format for alert definitions, ensuring consistency with the updated values.yaml documentation.