Skip to content

Fix npm audit vulnerabilities - #383

Merged
chalin merged 5 commits into
cncf:mainfrom
chalin:chalin-m24-audit-fix-2026-0824
Oct 8, 2026
Merged

chalin merged 5 commits into
cncf:mainfrom
chalin:chalin-m24-audit-fix-2026-0824

Conversation

@chalin

@chalin chalin commented Aug 24, 2026 •

Copy link
Copy Markdown
Collaborator
  • Scope:
    • in-range lockfile refresh for every advisory whose fix the declared ranges already admit; riders: browserslist data, express/body-parser patches
    • overrides where a parent's range excludes the fix: katex, smol-toml, markdownlint-cli's js-yaml, tinypool; carries the existing serialize-javascript and sockjs uuid overrides, still needed
    • drops the webpackbar override and its postinstall notice, obsolete since @docusaurus/bundler 3.10.2; package.json notes when each remaining override can go
  • Out of scope:
    • http-cache-semantics: fix is in range but under the 7-day release cooldown until 10-11 (follow-up)
    • root postcss-selector-parser 6.x: needs Docusaurus v4 (canary only)
    • basic-ftp (reached only for an ftp:// PAC file, dev) and braces (no fix published)
    • typecheck failure under TypeScript 7 (pre-existing on main)
  • Audit: 77 (18 critical) on main → 48 (0 critical); every new version clears the 7-day cooldown
  • Risk notes:
    • tinypool 2.x: Docusaurus loads it only under future.faster.ssgWorkerThreads (off here); a build with the flag forced on passes
    • katex 0.16 → 0.18: reached only via markdownlint's math extension (lint time)
  • Verified locally: npm ci, build, format/markdown/spelling checks, unit tests, dev server

@netlify

netlify Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cncf-techdocs ready!

Name Link
🔨 Latest commit 4f2b137
🔍 Latest deploy log https://app.netlify.com/projects/cncf-techdocs/deploys/6ac701f7810e3c000882d229
😎 Deploy Preview https://deploy-preview-383--cncf-techdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chalin
chalin force-pushed the chalin-m24-audit-fix-2026-0824 branch from 67f06f3 to ee4258e Compare August 26, 2026 17:14
chalin added 4 commits October 7, 2026 22:08
- Resolves only within declared ranges, under the 7-day release-age cooldown
- Clears both non-Docusaurus criticals (proxy-addr, shell-quote) and the image-size DoS chain
- Riders: browserslist data packages, express/body-parser patch releases

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
- Lifts katex, smol-toml and markdownlint-cli's js-yaml past their advisories, each override staying on its current major
- Pins serialize-javascript and sockjs's uuid to patched majors, since their Docusaurus parents still request the vulnerable ranges
- Admits only releases older than the 7-day cooldown

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
- Clears the moderate advisory for the 15 copies whose parents already accept 7.x
- Leaves the root 6.x copy, which the cssnano 6 chain under Docusaurus 3 still requires

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
- Clears both critical tinypool advisories, which npm also reports against tinypool's `@docusaurus/*` parents
- Matches the tinypool 2.x range used by Docusaurus v4 canaries
- Never loaded by default: Docusaurus uses tinypool only when `future.faster.ssgWorkerThreads` is on, and a forced-pool build passes on 2.2.0

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin
chalin force-pushed the chalin-m24-audit-fix-2026-0824 branch from 7702268 to 3bc76ec Compare October 8, 2026 02:20
@chalin chalin changed the title Fix npm audit vulnerabilities (criticals + highs; add overrides) Fix npm audit vulnerabilities Oct 8, 2026
- Drops the webpackbar override and its postinstall notice: `@docusaurus/bundler` 3.10.2 already requires webpackbar 7, so the resolved tree is unchanged
- Names, per remaining override, the parent whose update makes it removable, since npm never flags a redundant override

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin
chalin marked this pull request as ready for review October 8, 2026 02:49
@chalin
chalin enabled auto-merge (squash) October 8, 2026 02:50
@chalin

chalin commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

Ready for review @nate-double-u

@nate-double-u nate-double-u left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx @chalin

@chalin
chalin merged commit 766086c into cncf:main Oct 8, 2026
9 checks passed
@chalin
chalin deleted the chalin-m24-audit-fix-2026-0824 branch October 10, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants