Repository navigation
feat(ENG-15434): Add skills upstream command - #575
Open
pmcguckin-cloudsmith wants to merge 3 commits into
Open
pmcguckin-cloudsmith wants to merge 3 commits into
pmcguckin-cloudsmith wants to merge 3 commits into
Conversation
pmcguckin-cloudsmith
requested review from
a team and
cloudsmith-bot
as code owners
October 30, 2026 14:54
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Registering skills without adding a matching URL to the test mapping breaks the upstream key-set assertion and causes the parametrized integration test to raise KeyError: 'skills' before exercising the new commands.
1 open issue
What changed in this PR
Adds cloudsmith upstream skills to the CLI’s existing upstream-management commands for ENG-15434.
Changes:
- Registers
skillsfor upstream list, create, update, and delete commands. - Raises the minimum
cloudsmith-apiversion to 2.0.42 and updates the lockfile.
| File | Description |
|---|---|
uv.lock |
Pins cloudsmith-api 2.0.42 and updates package metadata. |
pyproject.toml |
Requires cloudsmith-api>=2.0.42,<3.0. |
cloudsmith_cli/cli/commands/upstream.py |
Adds skills to the supported upstream formats. |
Review effort: Balanced
darahayes
approved these changes
Oct 30, 2026
pmcguckin-cloudsmith
force-pushed
the
pmcguckin-cloudsmith/ENG-15434/add-skills-upstream-command
branch
2 times, most recently
from
October 30, 2026 15:17
e5b6e36 to
422a90a
Compare
pmcguckin-cloudsmith
force-pushed
the
pmcguckin-cloudsmith/ENG-15434/add-skills-upstream-command
branch
from
October 30, 2026 15:37
422a90a to
46c9061
Compare
adrian-guillen
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for ENG-15434
Type of Change
Additional Notes