Repository navigation
fix(no-ticket): show the dependencies help for list deps - #546
Open
cloudsmith-iduffy wants to merge 3 commits into
Open
cloudsmith-iduffy wants to merge 3 commits into
cloudsmith-iduffy wants to merge 3 commits into
Conversation
The list dependencies command copied the docstring of the entitlements list command. Its help showed the entitlements text. The command now copies the docstring of list_dependencies. The docstring is in STE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix matches the reported issue, includes regression coverage, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Fixes cloudsmith list deps --help to show dependency help instead of entitlement help, without changing dependency retrieval.
Changes:
- Corrects the wrapper’s help source to
list_dependencies. - Clarifies dependency help text and adds type annotations.
- Adds a regression test and changelog entry.
| File | Description |
|---|---|
cloudsmith_cli/cli/tests/commands/test_list.py |
Adds regression coverage for dependency help text. |
cloudsmith_cli/cli/commands/list_.py |
Corrects the wrapped function and annotates the wrapper. |
cloudsmith_cli/cli/commands/dependencies.py |
Clarifies the shared help text and adds parameter types. |
CHANGELOG.md |
Documents the help correction. |
Review effort: Balanced
cloudsmith-iduffy
marked this pull request as ready for review
October 24, 2026 17:52
cloudsmith-iduffy
enabled auto-merge (squash)
October 24, 2026 17:52
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@copilot resolve the merge conflicts on this branch. |
…s-help # Conflicts: # CHANGELOG.md Co-authored-by: cloudsmith-iduffy <178375997+cloudsmith-iduffy@users.noreply.github.com>
auto-merge was automatically disabled
October 29, 2026 11:04
Head branch was pushed to by a user without write access
Contributor
Merged |
tigh-latte
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cloudsmith list deps --helpshowed the help for the entitlements list. Thelist dependencieswrapper inlist_.pyusedfunctools.wraps(entitlements.list_entitlements), so Click took the entitlements docstring. It now wrapsdependencies.list_dependencies.I also rewrote the
list_dependenciesdocstring in plain English. It now says what the command lists: the direct dependencies of a package, from the package dependencies endpoint, with the type, name, version operator and version of each.cloudsmith deps --helpuses the same docstring.Before:
After:
Type of Change
Additional Notes
I checked every other
functools.wrapsand__doc__use undercli/commands(entitlements, quarantine, dependencies, upstream). They all point at the right function. A new test checks thatlist deps --helpnames dependencies.🤖 Generated with Claude Code