Repository navigation
Conversation
Upgrade the barman-cloud library to a version that includes cloudnative-pg/barman-cloud#310, which adds `zstd` to the `DataBackupConfiguration.compression` enum. Regenerate the ObjectStore CRD and the release manifest, and update the compression docs so that `zstd` is no longer listed as WAL-only. Barman 3.20.0 added `--zstd` to `barman-cloud-backup`; the sidecar image already ships barman 3.20.1 with the `zstandard` extra, and `barman-cloud-restore` picks the decompressor from the `.tar.zst` suffix recorded in `backup.info`, so no plugin code changes are needed. The library bump also pulls in `s3AddressingStyle` (cloudnative-pg/barman-cloud#288), which therefore appears in the CRD. Closes cloudnative-pg#1104 Signed-off-by: Daniel Garcia Sardina <dgsardina@navarino.gr>
joao00001
left a comment
There was a problem hiding this comment.
Tested on kind (CNPG 1.28.1, plugin release manifest with the CRD from this PR applied on top, RustFS from hack/object-store):
- the release CRD rejects data.compression: zstd, the PR CRD accepts it;
- a backup produced base//data.tar.zst (6.38 MB vs 6.97 MB for gzip on the same 39 MB cluster), WALs in .zst;
- a new cluster bootstrapped from it via bootstrap.recovery came up healthy with identical data (row count and md5 match).
One nit on the description: backup.info reports compression=None for both the zstd and the gzip backup, so barman-cloud-restore infers the decompressor from the object suffix, not from a value recorded in backup.info. Behaviour is correct, just the wording.
As a side note, the library bump also brings s3AddressingStyle into the CRD; since the commit message only mentions zstd, it won’t show up in the release-please changelog.
joao00001
left a comment
There was a problem hiding this comment.
Tested again against the latest stable CNPG (1.30.1), same results.
|
Thanks for testing on both CNPG versions. You're right on both counts: |
Upgrade the barman-cloud library to a version that includes
cloudnative-pg/barman-cloud#310, which adds
zstdto theDataBackupConfiguration.compressionenum. Regenerate the ObjectStoreCRD and the release manifest, and update the compression docs so that
zstdis no longer listed as WAL-only.Barman 3.20.0 added
--zstdtobarman-cloud-backup; the sidecar imagealready ships barman 3.20.1 with the
zstandardextra, andbarman-cloud-restorepicks the decompressor from the.tar.zstsuffixof the uploaded object, so no plugin code changes are needed.
The library bump also pulls in
s3AddressingStyle(cloudnative-pg/barman-cloud#288), which therefore appears in the CRD.
feat(api): expose s3AddressingStyle from barman-cloud (cloudnative-pg/barman-cloud#288)
Closes #1104
The pseudo-version can be replaced with
v0.7.0once cloudnative-pg/barman-cloud#303 is merged; renovate will do that automatically.