Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Debug request logging currently serializes every HTTP header value, including credentials in headers such as
AuthorizationandCookie. This change logs a redacted copy of the headers, retaining header names and value counts. The request sent to the origin is unchanged.The regression test checks the structured debug entry and verifies that the original request headers remain intact.
Fixes #1372.
Checks
CGO_ENABLED=0 go test -mod=readonly ./proxy— passedCGO_ENABLED=0 golangci-lint run ./proxy— passedmake test lintcould not complete locally: an unrelatedingress/TestFunnelIdleTimeouttest stalled waiting for ICMP on this macOS host. Repository-wide lint also reports four findings in unchanged files (carrier/websocket_test.goandcmd/cloudflared/tunnel/cmd.go).